First draft of subgroup normalization#39
Draft
bethac07 wants to merge 3 commits into
Draft
Conversation
Member
|
Worked for me. Minor suggestion:
Bigger request:
|
Member
|
I went ahead and wrote the "Bigger Request" because I wanted it for the batch I was processing. I have tested it on the one batch I was processing but have not otherwise done extensive testing. |
Member
|
We discussed today that we want to abstract the subgroup further and create a separate option |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Might be made unnecessary by cytomining/pycytominer#154, but that's TBD. @ErinWeisbart, can you test when you get to the profiles stage of the cell painting project you just started? LMK if the implementation isn't self-evident in what you'd do to change the metadata and/or the actual config file you run.