Skip to content

Commit 8568a35

Browse files
committed
Fixes to build with Python 3.13 only.
Remove old visual studio vars (Python 2.7 & 3.4). Update build instructions.
1 parent ddd479a commit 8568a35

3 files changed

Lines changed: 8 additions & 27 deletions

File tree

docs/Build-instructions.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -281,16 +281,21 @@ mkdir build/
281281
cd build/
282282
```
283283

284-
2) Download CEF binaries from [Spotify Automated Builds](https://cef-builds.spotifycdn.com/index.html).
284+
2) Install python dependencies:
285+
```
286+
pip install --upgrade -r ../tools/requirements.txt
287+
````
288+
289+
3) Download CEF binaries from [Spotify Automated Builds](https://cef-builds.spotifycdn.com/index.html).
285290
The version of the binaries must match exactly the CEF version
286291
from the "cefpython/src/version/" directory (look for CEF_VERSION
287292
constant in .h file).
288293
289-
3) Extract the downloaded archive eg.
294+
4) Extract the downloaded archive eg.
290295
"cef_binary_3.2883.1553.g80bd606_windows32.tar.bz2"
291296
in the build/ directory (using "extract here" option)
292297
293-
4) Run the automate.py tool. After it completes you should see a new
298+
5) Run the automate.py tool. After it completes you should see a new
294299
directory eg. "cef55_3.2883.1553.g80bd606_win32/".
295300
```
296301
python ../tools/automate.py --prebuilt-cef

tools/automate.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -677,10 +677,6 @@ def prepare_build_command(build_lib=False, vcvars=None):
677677
command = list()
678678
if platform.system() == "Windows":
679679
if build_lib:
680-
if vcvars == VS2010_VCVARS:
681-
# When using WinSDK 7.1 vcvarsall.bat is broken. Instead
682-
# env variables are queried using setuptools.msvc.
683-
return command
684680
if vcvars:
685681
command.append(vcvars)
686682
else:
@@ -689,8 +685,6 @@ def prepare_build_command(build_lib=False, vcvars=None):
689685
else:
690686
if int(Options.cef_branch) >= 2704:
691687
command.append(VS2015_VCVARS)
692-
else:
693-
command.append(VS2013_VCVARS)
694688
command.append(VS_PLATFORM_ARG)
695689
command.append("&&")
696690
return command
@@ -867,8 +861,6 @@ def copy_app(app):
867861

868862
def get_available_python_compilers():
869863
all_python_compilers = OrderedDict([
870-
("2008", VS2008_VCVARS),
871-
("2010", VS2010_VCVARS),
872864
("2015", VS2015_VCVARS),
873865
])
874866
ret_compilers = OrderedDict()

tools/common.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -221,22 +221,6 @@
221221

222222
VS2015_VCVARS = (r"C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat")
223223

224-
# Required for building old CEF branches < 2704
225-
VS2013_VCVARS = ("C:\\Program Files (x86)\\Microsoft Visual Studio 12.0"
226-
"\\VC\\vcvarsall.bat")
227-
228-
# Python 3.4
229-
VS2010_VCVARS = ("C:\\Program Files (x86)\\Microsoft Visual Studio 10.0"
230-
"\\VC\\vcvarsall.bat")
231-
232-
# Python 2.7
233-
VS2008_VCVARS = ("C:\\Program Files (x86)\\Microsoft Visual Studio 9.0"
234-
"\\VC\\vcvarsall.bat")
235-
236-
if WINDOWS and not os.path.exists(VS2008_VCVARS):
237-
VS2008_VCVARS = (os.environ["LOCALAPPDATA"]+"\\Programs\\Common\\Microsoft"
238-
"\\Visual C++ for Python\\9.0\\vcvarsall.bat")
239-
240224
# -----------------------------------------------------------------------------
241225

242226

0 commit comments

Comments
 (0)