refactor: small changes regarding logging and magic number

Author: d-Rickyy-b

certleak/analyzers/tldanalyzer.py

@@ -33,7 +33,7 @@ def match(self, update):
                 for tld in self.filtered_tlds:
                     if extract_result.suffix == tld and not any(word in full_domain for word in self.blacklist):
                         matches.append(full_domain)
-            except Exception as e:
-                self.logger.error("During matching of an update, the following exception occurred: %s", e)
+            except Exception:
+                self.logger.exception("During matching of an update, an exception occurred")
 
         return set(matches)

certleak/analyzers/wildcardcertanalyzer.py

@@ -28,8 +28,8 @@ def match(self, update):
         for full_domain in update.all_domains:
             try:
                 extract_result = tldextract.extract(full_domain)
-            except Exception as e:
-                self.logger.error("During matching of an update, the following exception occurred: %s", e)
+            except Exception:
+                self.logger.exception("During matching of an update, an exception occurred")
                 continue
 
             if extract_result.subdomain == "*" and not any(word in full_domain for word in self.blacklist):

certleak/core/actionhandler.py

@@ -75,5 +75,5 @@ def _perform_action_wrapper(self, action, update, analyzer, matches):
         try:
             self.logger.debug("Performing action '%s' on update '%s' matched by analyzer '%s'!", action.name, update.all_domains, analyzer.identifier)
             action.perform(update, analyzer.identifier, matches)
-        except Exception as e:
-            self.logger.error("While performing the action '%s' the following exception occurred: '%s'", action.name, e)
+        except Exception:
+            self.logger.exception("While performing the action '%s' an exception occurred", action.name)

certleak/core/certstreamwrapper.py

@@ -53,8 +53,8 @@ def _fill_queue(self, message, context):
         try:
             msg = Message.from_dict(message)
             update = msg.update
-        except Exception as e:
-            self.logger.error("Something went wrong while de_jsoning: %s", e)
+        except Exception:
+            self.logger.exception("Something went wrong while de_jsoning")
             self.error_counter += 1
             return
         else:
@@ -65,7 +65,8 @@ def _fill_queue(self, message, context):
                 self.processed_domains.add(domain)
 
         time_passed = int(time.time()) - self.last_info
-        if time_passed >= 60:
+        minute_in_seconds = 60
+        if time_passed >= minute_in_seconds:
             format_str = "Processed {0} updates ({1} unique domains) during the last {2} seconds. {3:.1f} domains/s, {4:.1f} certs/s"
             formatted_str = format_str.format(
                 self.update_counter, len(self.processed_domains), time_passed, len(self.processed_domains) / time_passed, self.update_counter / time_passed