refactor: prevent string concat

d-Rickyy-b · d-Rickyy-b · commit dbeedff516a4 · 2024-12-20T01:16:16.000+01:00
diff --git a/certleak/database/sqlitedb.py b/certleak/database/sqlitedb.py
@@ -81,7 +81,7 @@ def _insert_data(self, update):
             self.cursor.execute("INSERT INTO domains (domain, cert_fingerprint, stored_at) VALUES (?, ?, ?)", (domain, cert.fingerprint, now))
             self.db.commit()
         self.cursor.execute(
-            "INSERT INTO certs (fingerprint, not_before, not_after, serial_number, all_domains, subjectCN, stored_at) " "VALUES (?, ?, ?, ?, ?, ?, ?)",
+            "INSERT INTO certs (fingerprint, not_before, not_after, serial_number, all_domains, subjectCN, stored_at) VALUES (?, ?, ?, ?, ?, ?, ?)",
             (cert.fingerprint, cert.not_before, cert.not_after, cert.serial_number, ", ".join(cert.all_domains), cert.subject.CN, now),
         )
         self.db.commit()

Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ def _insert_data(self, update):`
`81`	`81`	`self.cursor.execute("INSERT INTO domains (domain, cert_fingerprint, stored_at) VALUES (?, ?, ?)", (domain, cert.fingerprint, now))`
`82`	`82`	`self.db.commit()`
`83`	`83`	`self.cursor.execute(`
`84`		`- "INSERT INTO certs (fingerprint, not_before, not_after, serial_number, all_domains, subjectCN, stored_at) " "VALUES (?, ?, ?, ?, ?, ?, ?)",`
	`84`	`+ "INSERT INTO certs (fingerprint, not_before, not_after, serial_number, all_domains, subjectCN, stored_at) VALUES (?, ?, ?, ?, ?, ?, ?)",`
`85`	`85`	`(cert.fingerprint, cert.not_before, cert.not_after, cert.serial_number, ", ".join(cert.all_domains), cert.subject.CN, now),`
`86`	`86`	`)`
`87`	`87`	`self.db.commit()`