fix: always include all_domains in json output

d-Rickyy-b · d-Rickyy-b · commit 1d3a6e475f81 · 2024-01-17T00:03:26.000+01:00
Previously the all_domains would be absent from the json if it was empty. This means that clients that expected the array could crash. Related to #26
diff --git a/internal/certstream/models.go b/internal/certstream/models.go
@@ -104,7 +104,7 @@ type Source struct {
 }
 
 type LeafCert struct {
-	AllDomains         []string   `json:"all_domains,omitempty"`
+	AllDomains         []string   `json:"all_domains"`
 	AsDER              string     `json:"as_der,omitempty"`
 	Extensions         Extensions `json:"extensions"`
 	Fingerprint        string     `json:"fingerprint"`

Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ type Source struct {`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`type LeafCert struct {`
`107`		- AllDomains []string `json:"all_domains,omitempty"`
	`107`	+ AllDomains []string `json:"all_domains"`
`108`	`108`	AsDER string `json:"as_der,omitempty"`
`109`	`109`	Extensions Extensions `json:"extensions"`
`110`	`110`	Fingerprint string `json:"fingerprint"`