Skip to content

Commit b9a3af0

Browse files
committed
refactor: use slices.Contains instead of custom loop
1 parent ef7b842 commit b9a3af0

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

internal/certificatetransparency/ct-parser.go

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"hash"
1212
"log"
1313
"math/big"
14+
"slices"
1415
"strings"
1516
"time"
1617

@@ -132,14 +133,7 @@ func leafCertFromX509cert(cert x509.Certificate) models.LeafCert {
132133

133134
leafCert.Subject = buildSubject(cert.Subject)
134135
if *leafCert.Subject.CN != "" && !leafCert.IsCA {
135-
domainAlreadyAdded := false
136-
// TODO check if CN matches domain regex
137-
for _, domain := range leafCert.AllDomains {
138-
if domain == *leafCert.Subject.CN {
139-
domainAlreadyAdded = true
140-
break
141-
}
142-
}
136+
domainAlreadyAdded := slices.Contains(leafCert.AllDomains, *leafCert.Subject.CN)
143137

144138
if !domainAlreadyAdded {
145139
leafCert.AllDomains = append(leafCert.AllDomains, *leafCert.Subject.CN)

0 commit comments

Comments
 (0)