support RN0.49#75
Open
windwang wants to merge 4 commits into
Open
Conversation
|
I don't think this will be merged, it hasn't been any activity in this repo since 5 Jul 2016. The fork |
recs182
reviewed
Jan 30, 2018
There was a problem hiding this comment.
I saw this approach to fix this problem in packages like rc-maps and rc-fbsdk and I thinks it`s more interesting.
// if ViewPropTypes is not defined fall back to View.propType (to support RN < 0.44)
const viewPropTypes = ViewPropTypes || View.propTypes;
const propTypes = {
data: PropTypes.array,
onChange: PropTypes.func,
initValue: PropTypes.string,
style: viewPropTypes.style,
selectStyle: viewPropTypes.style,
optionStyle: viewPropTypes.style,
optionTextStyle: Text.propTypes.style,
sectionStyle: viewPropTypes.style,
sectionTextStyle: Text.propTypes.style,
cancelStyle: viewPropTypes.style,
cancelTextStyle: Text.propTypes.style,
overlayStyle: viewPropTypes.style,
cancelText: PropTypes.string
};
|
That's the same approach as the fork |
|
I switched to rc-modal-selector since my only problem was this repo... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.