Skip to content

support RN0.49#75

Open
windwang wants to merge 4 commits into
d-a-n:masterfrom
windwang:master
Open

support RN0.49#75
windwang wants to merge 4 commits into
d-a-n:masterfrom
windwang:master

Conversation

@windwang

Copy link
Copy Markdown

No description provided.

@mikaello

Copy link
Copy Markdown

I don't think this will be merged, it hasn't been any activity in this repo since 5 Jul 2016. The fork react-native-modal-selector is RN 0.49 compatible.

@recs182 recs182 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this approach to fix this problem in packages like rc-maps and rc-fbsdk and I thinks it`s more interesting.

// if ViewPropTypes is not defined fall back to View.propType (to support RN < 0.44)
const viewPropTypes = ViewPropTypes || View.propTypes;

const propTypes = {
    data: PropTypes.array,
    onChange: PropTypes.func,
    initValue: PropTypes.string,
    style: viewPropTypes.style,
    selectStyle: viewPropTypes.style,
    optionStyle: viewPropTypes.style,
    optionTextStyle: Text.propTypes.style,
    sectionStyle: viewPropTypes.style,
    sectionTextStyle: Text.propTypes.style,
    cancelStyle: viewPropTypes.style,
    cancelTextStyle: Text.propTypes.style,
    overlayStyle: viewPropTypes.style,
    cancelText: PropTypes.string
};

@mikaello

Copy link
Copy Markdown

That's the same approach as the fork react-native-modal-selector has taken.

@recs182

recs182 commented Jan 30, 2018

Copy link
Copy Markdown

I switched to rc-modal-selector since my only problem was this repo...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants