some fixes required to align with React 15.5 and React-Native 0.44#90
Open
ktownsend-cbre wants to merge 2 commits into
Open
some fixes required to align with React 15.5 and React-Native 0.44#90ktownsend-cbre wants to merge 2 commits into
ktownsend-cbre wants to merge 2 commits into
Conversation
As of react 15.5, PropTypes has moved to its own library.
Also fixed a warning about keyboardShouldPersistTaps needing to be "always" rather than {true}.
Author
|
I didn't notice all the open pull requests before submitting mine. Clearly this project has been abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React 15.5 moved PropTypes to its own module prop-types.
React-Native 0.44 deprecated View.propTypes in favor of ViewPropTypes.
ScrollView property keyboardShouldPersistTaps expects "always" value instead of implied value; currently just results in a warning.