Open
Conversation
App metadata and icons are now embedded directly into the host-agent binary via go:embed, eliminating the runtime dependency on the apps/ directory. - Add apps/registry.go with //go:embed */metadata.yaml and */icon.png - Switch catalog.Loader to use io/fs.FS internally; add NewLoaderFromFS - Server and configure subcommand use embedded registry instead of appsDir - Icon serving reads from embedded FS instead of filesystem - Remove AppsDir from Config and ServerConfig (no longer needed) - Update tests to reflect embedded catalog behavior - Remove manual appconfig/register.go step from adding-app docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/registry.gowith//go:embed */metadata.yamland*/icon.png— all app metadata and icons are now embedded into the host-agent binary at compile timecatalog.Loaderto useio/fs.FSinternally; addNewLoaderFromFSconstructor for the embedded FS, keepingNewLoader(dir)for testsconfiguresubcommand use the embedded registry instead of reading from a runtimeappsDirpathAppsDirfromConfigandServerConfig— no longer needed at runtimeTest plan
./bloud smoke --buildend-to-end validation