chore: address code quality items Q1-Q4 from IMPROVEMENTS.md#211
Merged
Conversation
- Q1: merge prettier.config.yaml into .prettierrc so the prettier CLI enforces single quotes and other style rules (previously silently ignored). Reformat 58 files to match the unified config. - Q2: remove dead manualChunks rule for moment.js (moment was removed in 500d6ff). - Q3: fix German translation for error.card_delete (said "Boards", should be "Karte"). - Q4: fix Spanish translation for error.card_delete (said "tablero", should be "tarjeta"). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Q1–Q4 were addressed in this PR. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the four code quality items (Q1–Q4) from IMPROVEMENTS.md:
prettier.config.yamlwas silently ignored because.prettierrctook precedence; the YAML's style rules (singleQuote,semi,trailingComma,tabWidth) were only enforced via ESLint, not byprettierCLI. Merged the rules into.prettierrc, deletedprettier.config.yaml, and reformatted 58 files to match.momentchunk rule fromvite.config.js.moment.jswas removed in 500d6ff; themanualChunksentry never matched anything.error.card_deletetranslation: said "Boards" (board), now says "Karte" (card).error.card_deletetranslation: said "tablero" (board), now says "tarjeta" (card).The bulk of the diff is auto-formatting from Q1; the substantive changes are in
.prettierrc,prettier.config.yaml(deleted),vite.config.js,src/lang/de.json, andsrc/lang/es.json.Test plan
npm run lintpassesnpm run buildsucceeds with nomomentchunk in the outputerror.card_deletestrings now reference card/tarjeta🤖 Generated with Claude Code