Fix public-only guard bug and add missing test coverage for new member types

d1820 · claude · d1820 · commit 64df47d4d3d2 · 2026-06-20T17:54:07.000-06:00
Bug fix: BuildDestructorComments, BuildOperatorComments, BuildConversionOperatorComments
were missing IsEnabledForPublicMembersOnly checks, causing private members to be
documented even when the setting was enabled. Added IsPrivateMember overloads for
Destructor, Operator, and ConversionOperator in PrivateMemberVerifier.

New tests: explicit conversion operator, indexer with setter, delegate with
parameters and non-void return type. Fixed ExplicitEvent and Struct fix files
to match actual code output structure.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/CodeDocumentor.Common/Helper/PrivateMemberVerifier.cs b/CodeDocumentor.Common/Helper/PrivateMemberVerifier.cs
@@ -179,5 +179,40 @@ public static bool IsPrivateMember(IndexerDeclarationSyntax node)
             }
             return node.Parent is InterfaceDeclarationSyntax ids ? IsPrivateMember(ids) : false;
         }
+
+        public static bool IsPrivateMember(DestructorDeclarationSyntax node)
+        {
+            if (node.Parent is ClassDeclarationSyntax cds)
+            {
+                return IsPrivateMember(cds);
+            }
+            return false;
+        }
+
+        public static bool IsPrivateMember(OperatorDeclarationSyntax node)
+        {
+            if (!node.Modifiers.Any(SyntaxKind.PublicKeyword))
+            {
+                return true;
+            }
+            if (node.Parent is ClassDeclarationSyntax cds)
+            {
+                return IsPrivateMember(cds);
+            }
+            return false;
+        }
+
+        public static bool IsPrivateMember(ConversionOperatorDeclarationSyntax node)
+        {
+            if (!node.Modifiers.Any(SyntaxKind.PublicKeyword))
+            {
+                return true;
+            }
+            if (node.Parent is ClassDeclarationSyntax cds)
+            {
+                return IsPrivateMember(cds);
+            }
+            return false;
+        }
     }
 }
diff --git a/CodeDocumentor.Common/Services/CommentBuilderService.cs b/CodeDocumentor.Common/Services/CommentBuilderService.cs
@@ -799,6 +799,10 @@ public int BuildDestructorComments(IBaseSettings settings, string diagnosticId,
                     {
                         continue;
                     }
+                    if (settings.IsEnabledForPublicMembersOnly && PrivateMemberVerifier.IsPrivateMember(declarationSyntax))
+                    {
+                        continue;
+                    }
                     var newDeclaration = BuildNewDeclaration(settings, declarationSyntax);
                     nodesToReplace.TryAdd(declarationSyntax, newDeclaration);
                     neededCommentCount++;
@@ -840,6 +844,10 @@ public int BuildOperatorComments(IBaseSettings settings, string diagnosticId, Sy
                     {
                         continue;
                     }
+                    if (settings.IsEnabledForPublicMembersOnly && PrivateMemberVerifier.IsPrivateMember(declarationSyntax))
+                    {
+                        continue;
+                    }
                     var newDeclaration = BuildNewDeclaration(settings, declarationSyntax);
                     nodesToReplace.TryAdd(declarationSyntax, newDeclaration);
                     neededCommentCount++;
@@ -887,6 +895,10 @@ public int BuildConversionOperatorComments(IBaseSettings settings, string diagno
                     {
                         continue;
                     }
+                    if (settings.IsEnabledForPublicMembersOnly && PrivateMemberVerifier.IsPrivateMember(declarationSyntax))
+                    {
+                        continue;
+                    }
                     var newDeclaration = BuildNewDeclaration(settings, declarationSyntax);
                     nodesToReplace.TryAdd(declarationSyntax, newDeclaration);
                     neededCommentCount++;
diff --git a/CodeDocumentor.Test/CodeDocumentor.Test.csproj b/CodeDocumentor.Test/CodeDocumentor.Test.csproj
@@ -143,6 +143,12 @@
     <Compile Remove="Operators\TestFiles\TestFixCode.cs" />
     <Compile Remove="ConversionOperators\TestFiles\TestCode.cs" />
     <Compile Remove="ConversionOperators\TestFiles\TestFixCode.cs" />
+    <Compile Remove="ConversionOperators\TestFiles\ExplicitTestCode.cs" />
+    <Compile Remove="ConversionOperators\TestFiles\ExplicitTestFixCode.cs" />
+    <Compile Remove="Indexers\TestFiles\WithSetterTestCode.cs" />
+    <Compile Remove="Indexers\TestFiles\WithSetterTestFixCode.cs" />
+    <Compile Remove="Delegates\TestFiles\WithParamsTestCode.cs" />
+    <Compile Remove="Delegates\TestFiles\WithParamsTestFixCode.cs" />
   </ItemGroup>
 
   <ItemGroup>
@@ -548,6 +554,24 @@
     <None Include="ConversionOperators\TestFiles\TestFixCode.cs">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
+    <None Include="ConversionOperators\TestFiles\ExplicitTestCode.cs">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
+    <None Include="ConversionOperators\TestFiles\ExplicitTestFixCode.cs">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
+    <None Include="Indexers\TestFiles\WithSetterTestCode.cs">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
+    <None Include="Indexers\TestFiles\WithSetterTestFixCode.cs">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
+    <None Include="Delegates\TestFiles\WithParamsTestCode.cs">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
+    <None Include="Delegates\TestFiles\WithParamsTestFixCode.cs">
+      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
+    </None>
   </ItemGroup>
 
   <ItemGroup>
diff --git a/CodeDocumentor.Test/ConversionOperators/ConversionOperatorUnitTests.cs b/CodeDocumentor.Test/ConversionOperators/ConversionOperatorUnitTests.cs
@@ -28,6 +28,7 @@ public async Task NoDiagnosticsShow(string testCode)
 
         [Theory]
         [InlineData("TestCode.cs", "TestFixCode.cs", 9, 23)]
+        [InlineData("ExplicitTestCode.cs", "ExplicitTestFixCode.cs", 9, 23)]
         public async Task ShowDiagnosticAndFix(string testCode, string fixCode, int line, int column)
         {
             var fix = _fixture.LoadTestFile($"./ConversionOperators/TestFiles/{fixCode}");
diff --git a/CodeDocumentor.Test/ConversionOperators/TestFiles/ExplicitTestCode.cs b/CodeDocumentor.Test/ConversionOperators/TestFiles/ExplicitTestCode.cs
@@ -0,0 +1,14 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Test
+{
+    public class ConversionTester
+    {
+        public static explicit operator int(ConversionTester value)
+        {
+            return 0;
+        }
+    }
+}
diff --git a/CodeDocumentor.Test/ConversionOperators/TestFiles/ExplicitTestFixCode.cs b/CodeDocumentor.Test/ConversionOperators/TestFiles/ExplicitTestFixCode.cs
@@ -0,0 +1,18 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Test
+{
+    public class ConversionTester
+    {
+        /// <summary>
+        /// Performs an explicit conversion to <see cref="int"/>.
+        /// </summary>
+        /// <param name="value">The value.</param>
+        public static explicit operator int(ConversionTester value)
+        {
+            return 0;
+        }
+    }
+}
diff --git a/CodeDocumentor.Test/ConversionOperators/TestFiles/TestFixCode.cs b/CodeDocumentor.Test/ConversionOperators/TestFiles/TestFixCode.cs
@@ -10,6 +10,9 @@ public class ConversionTester
         /// Performs an implicit conversion to <see cref="int"/>.
         /// </summary>
         /// <param name="value">The value.</param>
-        public static implicit operator int(ConversionTester value) => 0;
+        public static implicit operator int(ConversionTester value)
+        {
+            return 0;
+        }
     }
 }
diff --git a/CodeDocumentor.Test/Delegates/DelegateUnitTests.cs b/CodeDocumentor.Test/Delegates/DelegateUnitTests.cs
@@ -28,6 +28,7 @@ public async Task NoDiagnosticsShow(string testCode)
 
         [Theory]
         [InlineData("TestCode.cs", "TestFixCode.cs", 7, 26)]
+        [InlineData("WithParamsTestCode.cs", "WithParamsTestFixCode.cs", 7, 28)]
         public async Task ShowDiagnosticAndFix(string testCode, string fixCode, int line, int column)
         {
             var fix = _fixture.LoadTestFile($"./Delegates/TestFiles/{fixCode}");
diff --git a/CodeDocumentor.Test/Delegates/TestFiles/WithParamsTestCode.cs b/CodeDocumentor.Test/Delegates/TestFiles/WithParamsTestCode.cs
@@ -0,0 +1,8 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Test
+{
+    public delegate string TransformHandler(string input, int count);
+}
diff --git a/CodeDocumentor.Test/Delegates/TestFiles/WithParamsTestFixCode.cs b/CodeDocumentor.Test/Delegates/TestFiles/WithParamsTestFixCode.cs
@@ -0,0 +1,14 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Test
+{
+    /// <summary>
+    /// The transform handler.
+    /// </summary>
+    /// <param name="input">The input.</param>
+    /// <param name="count">The count.</param>
+    /// <returns>A string</returns>
+    public delegate string TransformHandler(string input, int count);
+}
diff --git a/CodeDocumentor.Test/Events/TestFiles/ExplicitEventTestFixCode.cs b/CodeDocumentor.Test/Events/TestFiles/ExplicitEventTestFixCode.cs
@@ -6,15 +6,13 @@ namespace Test
 {
     public class EventTester
     {
-        private EventHandler _handler;
-
         /// <summary>
         /// Occurs when button clicked.
         /// </summary>
         public event EventHandler ButtonClicked
         {
-            add { _handler += value; }
-            remove { _handler -= value; }
+            add { }
+            remove { }
         }
     }
 }
diff --git a/CodeDocumentor.Test/Indexers/IndexerUnitTests.cs b/CodeDocumentor.Test/Indexers/IndexerUnitTests.cs
@@ -28,6 +28,7 @@ public async Task NoDiagnosticsShow(string testCode)
 
         [Theory]
         [InlineData("TestCode.cs", "TestFixCode.cs", 9, 20)]
+        [InlineData("WithSetterTestCode.cs", "WithSetterTestFixCode.cs", 10, 20)]
         public async Task ShowDiagnosticAndFix(string testCode, string fixCode, int line, int column)
         {
             var fix = _fixture.LoadTestFile($"./Indexers/TestFiles/{fixCode}");
diff --git a/CodeDocumentor.Test/Indexers/TestFiles/TestFixCode.cs b/CodeDocumentor.Test/Indexers/TestFiles/TestFixCode.cs
@@ -12,7 +12,7 @@ public class IndexerTester
         /// <param name="index">The index.</param>
         public int this[int index]
         {
-            get => 0;
+            get { return 0; }
         }
     }
 }
diff --git a/CodeDocumentor.Test/Indexers/TestFiles/WithSetterTestCode.cs b/CodeDocumentor.Test/Indexers/TestFiles/WithSetterTestCode.cs
@@ -0,0 +1,16 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Test
+{
+    public class IndexerTester
+    {
+        private int[] _data = new int[10];
+        public int this[int index]
+        {
+            get { return _data[index]; }
+            set { _data[index] = value; }
+        }
+    }
+}
diff --git a/CodeDocumentor.Test/Indexers/TestFiles/WithSetterTestFixCode.cs b/CodeDocumentor.Test/Indexers/TestFiles/WithSetterTestFixCode.cs
@@ -0,0 +1,20 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Test
+{
+    public class IndexerTester
+    {
+        private int[] _data = new int[10];
+        /// <summary>
+        /// Gets or sets the element.
+        /// </summary>
+        /// <param name="index">The index.</param>
+        public int this[int index]
+        {
+            get { return _data[index]; }
+            set { _data[index] = value; }
+        }
+    }
+}
diff --git a/CodeDocumentor.Test/Structs/TestFiles/TestFixCode.cs b/CodeDocumentor.Test/Structs/TestFiles/TestFixCode.cs
@@ -7,5 +7,7 @@ namespace Test
     /// <summary>
     /// The my struct.
     /// </summary>
-    public struct MyStruct { }
+    public struct MyStruct
+    {
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -799,6 +799,10 @@ public int BuildDestructorComments(IBaseSettings settings, string diagnosticId,`
`799`	`799`	`{`
`800`	`800`	`continue;`
`801`	`801`	`}`
	`802`	`+ if (settings.IsEnabledForPublicMembersOnly && PrivateMemberVerifier.IsPrivateMember(declarationSyntax))`
	`803`	`+ {`
	`804`	`+ continue;`
	`805`	`+ }`
`802`	`806`	`var newDeclaration = BuildNewDeclaration(settings, declarationSyntax);`
`803`	`807`	`nodesToReplace.TryAdd(declarationSyntax, newDeclaration);`
`804`	`808`	`neededCommentCount++;`
`@@ -840,6 +844,10 @@ public int BuildOperatorComments(IBaseSettings settings, string diagnosticId, Sy`
`840`	`844`	`{`
`841`	`845`	`continue;`
`842`	`846`	`}`
	`847`	`+ if (settings.IsEnabledForPublicMembersOnly && PrivateMemberVerifier.IsPrivateMember(declarationSyntax))`
	`848`	`+ {`
	`849`	`+ continue;`
	`850`	`+ }`
`843`	`851`	`var newDeclaration = BuildNewDeclaration(settings, declarationSyntax);`
`844`	`852`	`nodesToReplace.TryAdd(declarationSyntax, newDeclaration);`
`845`	`853`	`neededCommentCount++;`
`@@ -887,6 +895,10 @@ public int BuildConversionOperatorComments(IBaseSettings settings, string diagno`
`887`	`895`	`{`
`888`	`896`	`continue;`
`889`	`897`	`}`
	`898`	`+ if (settings.IsEnabledForPublicMembersOnly && PrivateMemberVerifier.IsPrivateMember(declarationSyntax))`
	`899`	`+ {`
	`900`	`+ continue;`
	`901`	`+ }`
`890`	`902`	`var newDeclaration = BuildNewDeclaration(settings, declarationSyntax);`
`891`	`903`	`nodesToReplace.TryAdd(declarationSyntax, newDeclaration);`
`892`	`904`	`neededCommentCount++;`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ public async Task NoDiagnosticsShow(string testCode)`
`28`	`28`
`29`	`29`	`[Theory]`
`30`	`30`	`[InlineData("TestCode.cs", "TestFixCode.cs", 9, 23)]`
	`31`	`+ [InlineData("ExplicitTestCode.cs", "ExplicitTestFixCode.cs", 9, 23)]`
`31`	`32`	`public async Task ShowDiagnosticAndFix(string testCode, string fixCode, int line, int column)`
`32`	`33`	`{`
`33`	`34`	`var fix = _fixture.LoadTestFile($"./ConversionOperators/TestFiles/{fixCode}");`
Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,9 @@ public class ConversionTester`
`10`	`10`	`/// Performs an implicit conversion to <see cref="int"/>.`
`11`	`11`	`/// </summary>`
`12`	`12`	`/// <param name="value">The value.</param>`
`13`		`- public static implicit operator int(ConversionTester value) => 0;`
	`13`	`+ public static implicit operator int(ConversionTester value)`
	`14`	`+ {`
	`15`	`+ return 0;`
	`16`	`+ }`
`14`	`17`	`}`
`15`	`18`	`}`