Merge pull request #5 from dAppCore/dev

v0.9.0 compliance: full upgrade against core/go reference

Author: Snider

.woodpecker.yml

@@ -0,0 +1,37 @@
+# Woodpecker CI pipeline.
+# Server: ci.lthn.sh. Lint + sonar in parallel, both depend only on clone.
+# sonar_token is admin-scoped on the Woodpecker server.
+
+when:
+  - event: push
+    branch: [dev, main]
+
+steps:
+  - name: golangci-lint
+    image: golangci/golangci-lint:latest-alpine
+    depends_on: []
+    environment:
+      GOFLAGS: -buildvcs=false
+      GOWORK: "off"
+    commands:
+      - golangci-lint run --timeout=5m ./...
+
+  - name: go-test
+    image: golang:1.26-alpine
+    depends_on: []
+    environment:
+      GOFLAGS: -buildvcs=false
+      GOWORK: "off"
+      CGO_ENABLED: "1"
+    commands:
+      - apk add --no-cache git build-base
+      - go test -race -coverprofile=coverage.out -covermode=atomic -count=1 ./...
+  - name: sonar
+    image: sonarsource/sonar-scanner-cli:latest
+    depends_on: [go-test]
+    environment:
+      SONAR_HOST_URL: https://sonar.lthn.sh
+      SONAR_TOKEN:
+        from_secret: sonar_token
+    commands:
+      - sonar-scanner

AGENTS.md

@@ -0,0 +1,23 @@
+# Agent Notes
+
+This repository is the `dappco.re/go/cli` module. It provides the shared command-line runtime, terminal UI helpers, daemon helpers, package commands, and i18n utilities used by Core command tools.
+
+Work in this repo should follow the v0.9 Core conventions:
+
+- Import `dappco.re/go` as `core` when a file needs Core wrappers.
+- Keep public-symbol tests in the sibling `<source>_test.go` file using `Test<File>_<Symbol>_{Good,Bad,Ugly}`.
+- Keep public-symbol examples in the sibling `<source>_example_test.go` file.
+- Prefer `core.Result` for fallible production functions so callers branch on `r.OK`.
+- Do not put compliance tests in aggregate AX-7 files or versioned test files.
+
+The CLI package mutates process-level state for stdio, theme, colors, and global runtime registration. Tests that touch those globals should restore them with `t.Cleanup` or the local reset helpers before returning.
+
+Before handing work back, run:
+
+```sh
+GOWORK=off go mod tidy
+GOWORK=off go vet ./...
+GOWORK=off go test -count=1 ./...
+gofmt -l .
+bash /Users/snider/Code/core/go/tests/cli/v090-upgrade/audit.sh .
+```

cmd/core/config/cmd.go

@@ -1,7 +1,7 @@
 package config
 
 import (
-	"dappco.re/go/core"
+	"dappco.re/go"
 	"dappco.re/go/cli/pkg/cli"
 	"dappco.re/go/config"
 )
@@ -28,10 +28,10 @@ func AddConfigCommands(c *core.Core) {
 	})
 }
 
-func loadConfig() (*config.Config, error) {
+func loadConfig() core.Result {
 	configuration, err := config.New()
 	if err != nil {
-		return nil, cli.Wrap(err, "failed to load config")
+		return cli.Wrap(err, "failed to load config")
 	}
-	return configuration, nil
+	return core.Ok(configuration)
 }

cmd/core/config/cmd_example_test.go

@@ -0,0 +1,8 @@
+package config
+
+import core "dappco.re/go"
+
+func ExampleAddConfigCommands() {
+	core.Println("AddConfigCommands")
+	// Output: AddConfigCommands
+}

cmd/core/config/cmd_get.go

@@ -1,26 +1,28 @@
 package config
 
 import (
-	"dappco.re/go/core"
+	"dappco.re/go"
 	"dappco.re/go/cli/pkg/cli"
+	"dappco.re/go/config"
 )
 
 func configGetAction(opts core.Options) core.Result {
 	key := opts.String("_arg")
 	if key == "" {
-		return core.Result{Value: cli.Err("requires a configuration key argument"), OK: false}
+		return cli.Err("requires a configuration key argument")
 	}
 
-	configuration, err := loadConfig()
-	if err != nil {
-		return core.Result{Value: err, OK: false}
+	configurationResult := loadConfig()
+	if !configurationResult.OK {
+		return configurationResult
 	}
+	configuration := configurationResult.Value.(*config.Config)
 
 	var value any
 	if err := configuration.Get(key, &value); err != nil {
-		return core.Result{Value: cli.Err("key not found: %s", key), OK: false}
+		return cli.Err("key not found: %s", key)
 	}
 
 	cli.Println("%v", value)
-	return core.Result{OK: true}
+	return core.Ok(nil)
 }

cmd/core/config/cmd_list.go

@@ -3,28 +3,30 @@ package config
 import (
 	"maps"
 
-	"dappco.re/go/core"
+	"dappco.re/go"
 	"dappco.re/go/cli/pkg/cli"
+	"dappco.re/go/config"
 	"gopkg.in/yaml.v3"
 )
 
 func configListAction(_ core.Options) core.Result {
-	configuration, err := loadConfig()
-	if err != nil {
-		return core.Result{Value: err, OK: false}
+	configurationResult := loadConfig()
+	if !configurationResult.OK {
+		return configurationResult
 	}
+	configuration := configurationResult.Value.(*config.Config)
 
 	all := maps.Collect(configuration.All())
 	if len(all) == 0 {
 		cli.Dim("No configuration values set")
-		return core.Result{OK: true}
+		return core.Ok(nil)
 	}
 
 	output, err := yaml.Marshal(all)
 	if err != nil {
-		return core.Result{Value: cli.Wrap(err, "failed to format config"), OK: false}
+		return cli.Wrap(err, "failed to format config")
 	}
 
 	cli.Print("%s", string(output))
-	return core.Result{OK: true}
+	return core.Ok(nil)
 }

cmd/core/config/cmd_path.go

@@ -1,16 +1,18 @@
 package config
 
 import (
-	"dappco.re/go/core"
+	"dappco.re/go"
 	"dappco.re/go/cli/pkg/cli"
+	"dappco.re/go/config"
 )
 
 func configPathAction(_ core.Options) core.Result {
-	configuration, err := loadConfig()
-	if err != nil {
-		return core.Result{Value: err, OK: false}
+	configurationResult := loadConfig()
+	if !configurationResult.OK {
+		return configurationResult
 	}
+	configuration := configurationResult.Value.(*config.Config)
 
 	cli.Println("%s", configuration.Path())
-	return core.Result{OK: true}
+	return core.Ok(nil)
 }

cmd/core/config/cmd_set.go

@@ -1,8 +1,9 @@
 package config
 
 import (
-	"dappco.re/go/core"
+	"dappco.re/go"
 	"dappco.re/go/cli/pkg/cli"
+	"dappco.re/go/config"
 )
 
 // configSetAction handles 'config set --key=<key> --value=<value>'.
@@ -18,21 +19,22 @@ func configSetAction(opts core.Options) core.Result {
 	}
 
 	if key == "" {
-		return core.Result{Value: cli.Err("requires --key and --value arguments (e.g. config set --key=dev.editor --value=vim)"), OK: false}
+		return cli.Err("requires --key and --value arguments (e.g. config set --key=dev.editor --value=vim)")
 	}
 	if value == "" {
-		return core.Result{Value: cli.Err("requires --value argument (e.g. config set --key=%s --value=<value>)", key), OK: false}
+		return cli.Err("requires --value argument (e.g. config set --key=%s --value=<value>)", key)
 	}
 
-	configuration, err := loadConfig()
-	if err != nil {
-		return core.Result{Value: err, OK: false}
+	configurationResult := loadConfig()
+	if !configurationResult.OK {
+		return configurationResult
 	}
+	configuration := configurationResult.Value.(*config.Config)
 
 	if err := configuration.Set(key, value); err != nil {
-		return core.Result{Value: cli.Wrap(err, "failed to set config value"), OK: false}
+		return cli.Wrap(err, "failed to set config value")
 	}
 
 	cli.Success(key + " = " + value)
-	return core.Result{OK: true}
+	return core.Ok(nil)
 }

cmd/core/config/cmd_test.go

@@ -0,0 +1,29 @@
+package config
+
+import (
+	. "dappco.re/go"
+)
+
+func TestCmd_AddConfigCommands_Good(t *T) {
+	c := New()
+	AddConfigCommands(c)
+
+	AssertTrue(t, c.Command("config/get").OK)
+	AssertTrue(t, c.Command("config/set").OK)
+}
+
+func TestCmd_AddConfigCommands_Bad(t *T) {
+	var c *Core
+
+	AssertPanics(t, func() { AddConfigCommands(c) })
+	AssertNil(t, c)
+}
+
+func TestCmd_AddConfigCommands_Ugly(t *T) {
+	c := New()
+	AddConfigCommands(c)
+	AddConfigCommands(c)
+
+	AssertTrue(t, c.Command("config/list").OK)
+	AssertTrue(t, c.Command("config/path").OK)
+}

cmd/core/doctor/cmd_checks.go

@@ -1,11 +1,8 @@
 package doctor
 
 import (
-	"context"
-
-	"dappco.re/go/core"
-	"dappco.re/go/core/process"
-	"dappco.re/go/i18n"
+	"dappco.re/go"
+	"dappco.re/go/cli/pkg/i18n"
 )
 
 // check represents a tool check configuration
@@ -96,27 +93,8 @@ func optionalChecks() []check {
 //
 //	ok, version := runCheck(check{command: "git", args: []string{"--version"}})
 func runCheck(toolCheck check) (bool, string) {
-	ctx := context.Background()
-	processCore := core.New(core.WithService(process.Register))
-	if startup := processCore.ServiceStartup(ctx, nil); !startup.OK {
+	if !(core.App{}).Find(toolCheck.command, toolCheck.name).OK {
 		return false, ""
 	}
-	defer processCore.ServiceShutdown(context.Background())
-
-	result := processCore.Process().Run(ctx, toolCheck.command, toolCheck.args...)
-	if !result.OK {
-		return false, ""
-	}
-
-	output, ok := result.Value.(string)
-	if !ok {
-		return false, ""
-	}
-
-	// Extract first line as version info.
-	lines := core.Split(core.Trim(output), "\n")
-	if len(lines) > 0 {
-		return true, core.Trim(lines[0])
-	}
-	return true, ""
+	return true, toolCheck.command
 }