Merge torrust#837: Prepare for edition 2024 by pinning pre-2024 dependencies

07a5a6b chore: prepare for edition 2024 by pinning pre-2024 dependencies (Cameron Garnham)

Pull request description:

  Several upstream crates have started shipping releases that require Rust edition 2024 (`rustc ≥ 1.85`). Rather than migrating the entire workspace to edition 2024 in one sweep, this PR takes the incremental approach: **pin or downgrade every transitive dependency that requires edition 2024** so the workspace stays on edition 2021 for now.

  ### What changed

  **Dependencies** — Downgraded `jsonwebtoken` from v10 to v9.3, pinned `rand` to 0.9, and locked ~30 transitive crates in Cargo.lock to their last edition-2021-compatible versions (notably `time`, `clap`, `image`, `uuid`, `tera`, and friends). The full pin table is documented in ADR-T-003.

  **MSRV raised to 1.83** — Even after all the edition-2024 pins, the remaining dependency floor (set by crates like `async-compression`, `crc`, `icu_*`, `pest*`) is rustc 1.83. The workspace `rust-version` is updated accordingly and a new **MSRV CI job** in the testing workflow ensures we don't regress.

  **Source changes** — `rand 0.9` renames `rand::RngExt` → `rand::Rng`; all call sites updated. One `clippy::missing_const_for_fn` allow added in the render-text-as-image package. No behavioural changes.

  **CI bumps** — `actions/checkout` v4→v6, `docker/setup-buildx-action` v3→v4, `docker/login-action` v3→v4, `actions/upload-artifact` v4→v7, `actions/github-script` v7→v8.

  **ADR housekeeping** — Moved `docs/adrs/` → adr using the `ADR-T-NNN` naming convention. Rewrote existing ADRs in formal style. Added ADR-T-003 documenting this decision, options considered, and the full list of pinned crates. Normalised cross-references across the render-text-as-image package (`§ADR R-NNN` → `ADR-R-NNN`).

  ### Why not just jump to edition 2024?

  Edition 2024 introduces new lints and language changes that touch a lot of first-party code. Migrating the edition is better done as a focused, standalone effort (tracked for a future ADR). This PR buys that time by keeping everything building and tested on edition 2021 while the ecosystem settles.

  ### Version bump

  Workspace version → **3.1.0-develop**.

ACKs for top commit:
  da2ce7:
    ACK 07a5a6b

Tree-SHA512: 8b62dcdfd2ecadb520ce9b223da95842afa68e6040ec788c210aae010154f9edcbf94621167f7e6badc99d7eae822b4292bd80fbb9fa13a582f09224218f9d70

Author: da2ce7

.github/workflows/container.yaml

@@ -26,7 +26,7 @@ jobs:
     steps:
       - id: setup
         name: Setup Toolchain
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
 
       - id: build
         name: Build
@@ -46,7 +46,7 @@ jobs:
 
       - id: checkout
         name: Checkout Repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - id: compose
         name: Compose
@@ -117,14 +117,14 @@ jobs:
 
       - id: login
         name: Login to Docker Hub
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           username: ${{ vars.DOCKER_HUB_USERNAME }}
           password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
 
       - id: setup
         name: Setup Toolchain
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
 
       - name: Build and push
         uses: docker/build-push-action@v6
@@ -158,14 +158,14 @@ jobs:
 
       - id: login
         name: Login to Docker Hub
-        uses: docker/login-action@v3
+        uses: docker/login-action@v4
         with:
           username: ${{ vars.DOCKER_HUB_USERNAME }}
           password: ${{ secrets.DOCKER_HUB_ACCESS_TOKEN }}
 
       - id: setup
         name: Setup Toolchain
-        uses: docker/setup-buildx-action@v3
+        uses: docker/setup-buildx-action@v4
 
       - name: Build and push
         uses: docker/build-push-action@v6

.github/workflows/coverage.yaml

@@ -19,7 +19,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - name: Install LLVM tools
         run: sudo apt-get update && sudo apt-get install -y llvm

.github/workflows/deployment.yaml

@@ -17,7 +17,7 @@ jobs:
     steps:
       - id: checkout
         name: Checkout Repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - id: setup
         name: Setup Toolchain
@@ -42,7 +42,7 @@ jobs:
     steps:
       - id: checkout
         name: Checkout Repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - id: setup
         name: Setup Toolchain

.github/workflows/e2e.yaml

@@ -22,7 +22,7 @@ jobs:
     steps:
       - id: checkout
         name: Checkout Repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - id: setup
         name: Setup Toolchain

.github/workflows/generate_coverage_pr.yaml

@@ -19,7 +19,7 @@ jobs:
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - name: Install LLVM tools
         run: sudo apt-get update && sudo apt-get install -y llvm
@@ -63,13 +63,13 @@ jobs:
       # Triggered sub-workflow is not able to detect the original commit/PR which is available
       # in this workflow.
       - name: Store PR number
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: pr_number
           path: pr_number.txt
 
       - name: Store commit SHA
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: commit_sha
           path: commit_sha.txt
@@ -78,7 +78,7 @@ jobs:
       # is executed by a different workflow `upload_coverage.yml`. The reason for this
       # split is because `on.pull_request` workflows don't have access to secrets.
       - name: Store coverage report in artifacts
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: codecov_report
           path: ./codecov.json

.github/workflows/labels.yaml

@@ -25,7 +25,7 @@ jobs:
     steps:
       - id: checkout
         name: Checkout Repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - id: sync
         name: Apply Labels from File

.github/workflows/testing.yaml

@@ -15,7 +15,7 @@ jobs:
     steps:
       - id: checkout
         name: Checkout Repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - id: setup
         name: Setup Toolchain
@@ -32,6 +32,50 @@ jobs:
         name: Run Formatting-Checks
         run: cargo fmt --check
 
+  msrv:
+    name: MSRV
+    runs-on: ubuntu-latest
+    needs: format
+
+    steps:
+      - id: checkout
+        name: Checkout Repository
+        uses: actions/checkout@v6
+
+      - id: msrv
+        name: Read MSRV from Cargo.toml
+        run: |
+          MSRV=$(sed -n 's/^rust-version = "\(.*\)"/\1/p' Cargo.toml | head -1)
+          echo "version=$MSRV" >> "$GITHUB_OUTPUT"
+
+      - id: setup
+        name: Setup Toolchain
+        uses: dtolnay/rust-toolchain@stable
+        with:
+          toolchain: ${{ steps.msrv.outputs.version }}
+
+      - id: cache
+        name: Enable Workflow Cache
+        uses: Swatinem/rust-cache@v2
+
+      - id: check
+        name: Run Build Checks
+        run: cargo check --workspace --all-targets --all-features
+
+      - id: imdl
+        name: Install Intermodal
+        run: |
+          rustup install stable
+          cargo +stable install imdl
+
+      - id: test-docs
+        name: Run Documentation Tests
+        run: cargo test --doc
+
+      - id: test
+        name: Run Unit Tests
+        run: cargo test --workspace --all-targets --all-features
+
   check:
     name: Static Analysis
     runs-on: ubuntu-latest
@@ -44,7 +88,7 @@ jobs:
     steps:
       - id: checkout
         name: Checkout Repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - id: setup
         name: Setup Toolchain
@@ -97,7 +141,7 @@ jobs:
     steps:
       - id: checkout
         name: Checkout Repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - id: setup
         name: Setup Toolchain
@@ -134,7 +178,7 @@ jobs:
     steps:
       - id: checkout
         name: Checkout Repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
 
       - id: setup
         name: Setup Toolchain

.github/workflows/upload_coverage_pr.yaml

@@ -22,7 +22,7 @@ jobs:
     steps:
       - name: "Download existing coverage report"
         id: prepare_report
-        uses: actions/github-script@v7
+        uses: actions/github-script@v8
         with:
           script: |
             var fs = require('fs');
@@ -96,7 +96,7 @@ jobs:
           echo "override_commit=$(<commit_sha.txt)" >> "$GITHUB_OUTPUT"
 
       - name: Checkout repository
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           ref: ${{ steps.parse_previous_artifacts.outputs.override_commit || '' }}
           path: repo_root

AGENTS.md

@@ -34,24 +34,41 @@ API, perhaps using `#[doc(hidden)]` helpers when appropriate.
 | Crate       | `pub(crate)` | `/src/tests/` |
 | Integration | `pub`        | `/tests/`     |
 
+
+## Test Doc-Headers
+
+Every test file (module) should maintain an index of the tests contained in the module-doc. The primary purpose is to make it easy to scan the test files to detect duplicates or overlapping coverage. Please opportunistically create if missing.
+
 ## Cross-Reference Conventions
 
 Eagerly corrected when spotted in **any** file!
 
 Cross-references use the `§` (section sign) prefix. Every reference
-carries a **package qualifier** — `T-` for Torrust —
-so the target document is never ambiguous.
+carries a **package qualifier** so the target document is never ambiguous.
+ADR references (`ADR-T-001`, `ADR-R-001`, …) are an exception — they
+use their own `ADR-<PREFIX>-<NNN>` form without the `§` prefix.
+
+| Prefix | Package              | Example document                     |
+|--------|----------------------|--------------------------------------|
+| `T-`   | Torrust (root crate) | *(none yet)*                         |
+| `R-`   | render-text-as-image | `packages/render-text-as-image/`     |
 
 ### General Rules
 
-- Use `§§` for ranges: e.g. `§§ALGO M-12.2–12.5`.
+- Use `§§` for ranges: e.g. `§§IDEA M-12.2–12.5`.
 - Bare `§N` (no label) is acceptable **within** a document that already
-  establishes context (e.g. inside `algorithm.md` itself), but in source
+  establishes context (e.g. inside `idea.md` itself), but in source
   code and cross-package references always use the fully qualified
   `§BOOK PACKAGE_PREFIX-N` form.
+- Example: `§SPEC R-1.1` refers to §1.1 of `packages/render-text-as-image/docs/specification.md`.
+- ADRs live in an `adr/` directory per package (`/adr/` for the
+  root crate) and use sequential numbering: `NNN-slug.md`. Referenced
+  as `ADR-T-001`, `ADR-R-001`, `ADR-R-002`.
 
 ## Replacing a File
 
+To avoid partial or corrupted writes, always replace files atomically:
+
 1. Read the file.
 2. Using the CLI, `rm` the file.
 3. Recreate the file.