added closed shard handling#25
Open
farvez10 wants to merge 2 commits into
Open
Conversation
farvez10
force-pushed
the
handling-closed-shards
branch
from
22e9943 to
1d92093
Compare
farvez10
force-pushed
the
handling-closed-shards
branch
from
1d92093 to
9e067bc
Compare
farvez10
commented
Feb 7, 2026
|
|
||
| func (k *Kinesumer) commitPeriodically() { | ||
| var checkPointTicker = time.NewTicker(k.commitInterval) | ||
| checkPointTicker := time.NewTicker(k.commitInterval) |
Author
There was a problem hiding this comment.
my "gofmt" tool's change, will change if not needed
| func (k *Kinesumer) getNextShardIterator( | ||
| ctx context.Context, stream, shardID string) (*string, error) { | ||
| ctx context.Context, stream, shardID string, | ||
| ) (*string, error) { |
Author
There was a problem hiding this comment.
my "gofmt" tool's change, will change if not needed
| func (k *Kinesumer) Consume( | ||
| streams []string) (<-chan *Record, error) { | ||
| streams []string, | ||
| ) (<-chan *Record, error) { |
Author
There was a problem hiding this comment.
my "gofmt" tool's change, will change if not needed
farvez10
force-pushed
the
handling-closed-shards
branch
from
0e0446d to
e3f85e4
Compare
farvez10
changed the title
Author
|
@mingrammer @cometkim @ElonPark @mooyoul |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing issues:
#26