File Downloads getting corrupted

[ikmckenz]

Using the FileTransferClient to download a file pretty consistently results in corrupted (and usually truncated) files. Perhaps there's some final flush that is missing or a race condition.

[ikmckenz]

Actually looks like this is throwing away any base64 file chunks that have the valid base64 character / in them: https://github.com/dacort/pyssm-client/blob/main/src/pyssm_client/file_transfer/client.py#L683

Simply removing this doesn't fix the issue, since the encode_cmd seems to be the first line in the data channel received data buffer. Starting from the second entry in the decoded lines (for line in lines[1:]) also doesn't fully fix it since there seems to be extra data in the buffer after the full file, but it's closest. Also errors="ignore" in the utf-8 decoding on line 674 will cause problems, but that seems separate.