ImToolsSmallList consistent method naming

Author: Maksim Volkau

src/FastExpressionCompiler.LightExpression/Expression.cs

@@ -5038,7 +5038,7 @@ public class BlockExpression : Expression, IArgumentProvider
     public override Type Type => Result.Type;
     public virtual IReadOnlyList<ParameterExpression> Variables => Tools.Empty<ParameterExpression>();
     public SmallList<Expression, Stack2<Expression>, NoArrayPool<Expression>> Expressions;
-    public Expression Result => Expressions.GetLastSurePresentItem(); // todo: @check what if no expressions?
+    public Expression Result => Expressions.GetLastSurePresentRef(); // todo: @check what if no expressions?
     public virtual int ArgumentCount => 0;
     public virtual Expression GetArgument(int index) => throw new NotImplementedException();
     internal BlockExpression(in SmallList<Expression, Stack2<Expression>, NoArrayPool<Expression>> expressions) =>

src/FastExpressionCompiler/FastExpressionCompiler.cs

@@ -806,7 +806,7 @@ public void PushBlockAndConstructLocalVars(IReadOnlyList<PE> blockVarExprs, ILGe
             private void PushVarInBlockMap(ParameterExpression pe, ushort blockIndex, ushort varIndex)
             {
                 ref var blocks = ref _varInBlock.Map.AddOrGetValueRef(pe, out _);
-                if (blocks.Count == 0 || (blocks.GetLastSurePresentItem() >>> 16) != blockIndex)
+                if (blocks.Count == 0 || (blocks.GetLastSurePresentRef() >>> 16) != blockIndex)
                     blocks.Add((uint)(blockIndex << 16) | varIndex);
             }
 
@@ -818,7 +818,7 @@ public void PopBlock()
                 {
                     ref var varBlocks = ref _varInBlock.Map.GetSurePresentEntryRef(i);
                     if (varBlocks.Value.Count == _blockCount)
-                        varBlocks.Value.RemoveLastSurePresentItem();
+                        varBlocks.Value.RemoveLastSurePresent();
                 }
                 --_blockCount;
             }
@@ -835,7 +835,7 @@ public int GetDefinedLocalVarOrDefault(ParameterExpression varParamExpr)
             {
                 ref var blocks = ref _varInBlock.Map.TryGetValueRef(varParamExpr, out var found);
                 return found && blocks.Count != 0 // rare case with the block count 0 may occur when we collected the block and vars, but not yet defined the variable for it
-                    ? (int)(blocks.GetLastSurePresentItem() & ushort.MaxValue)
+                    ? (int)(blocks.GetLastSurePresentRef() & ushort.MaxValue)
                     : -1;
             }
         }

src/FastExpressionCompiler/ImTools.cs

@@ -746,7 +746,7 @@ public interface ISmallList<T> : IIndexed<T>, IEnumerable<T>
     int TryGetIndex<TEq>(in T item, TEq eq = default) where TEq : struct, IEq<T>;
 
     /// <summary>Removes the last item from the list. List should not be empty.</summary>
-    void RemoveLastSurePresentItem();
+    void RemoveLastSurePresent();
 
     /// <summary>Clears the list.</summary>
     void Clear();
@@ -905,15 +905,15 @@ public void FreePooled()
     /// <summary>Returns last present item ref, assumes that the list is not empty!</summary>
     [UnscopedRef]
     [MethodImpl((MethodImplOptions)256)]
-    public ref T GetLastSurePresentItem()
+    public ref T GetLastSurePresentRef()
     {
         Debug.Assert(_count > 0, "Expecting that the list is not empty");
         return ref GetSurePresentRef(_count - 1);
     }
 
     /// <summary>Removes the last item from the list aka the Stack Pop. Assumes that the list is not empty!</summary>
     [MethodImpl((MethodImplOptions)256)]
-    public void RemoveLastSurePresentItem()
+    public void RemoveLastSurePresent()
     {
         Debug.Assert(_count > 0, "SmallList.RemoveLastSurePresentItem: Expecting that the list is not empty");
         GetSurePresentRef(_count - 1) = default;

test/FastExpressionCompiler.IssueTests/Issue499_InvalidProgramException_for_Sorting_and_comparison_function.cs

@@ -24,7 +24,7 @@ public void Run(TestRun t)
     }
 
     // Reproduces the sorting use-case from https://github.com/dadhi/FastExpressionCompiler/issues/499
-    // using the same nested-loop pattern as SortCompiler.Compile but minimised to a plain int[].
+    // using the same nested-loop pattern as SortCompiler.Compile but minimized to a plain int[].
     // The outer loop drives a quicksort-style partition; two inner loops advance the i/j cursors.
     public void Quicksort_partition_with_nested_loops(TestContext t)
     {
@@ -108,7 +108,7 @@ public void Quicksort_partition_with_nested_loops(TestContext t)
 
     // Reproduces the comparison-function use-case from https://github.com/dadhi/FastExpressionCompiler/issues/499
     // using the same Return(label, value) / goto pattern as SortCompiler.CompileComparisonFunction
-    // but minimised to a plain int comparison (DESC order, like the original failing test).
+    // but minimized to a plain int comparison (DESC order, like the original failing test).
     public void Comparison_function_with_goto_labels(TestContext t)
     {
         var left = Parameter(typeof(int), "left");

test/FastExpressionCompiler.UnitTests/ArithmeticOperationsTests.cs

@@ -22,9 +22,9 @@ public int Run()
             Can_sum_signed_bytes_converted_to_ints();
             Can_sum_all_primitive_numeric_types_that_define_binary_operator_add();
             Can_not_sum_with_checked_overflow();
-            Can_substract_all_primitive_numeric_types_that_define_binary_operator_substract();
-            Can_substract_with_unchecked_overflow();
-            Can_not_substract_with_checked_overflow();
+            Can_subtract_all_primitive_numeric_types_that_define_binary_operator_subtract();
+            Can_subtract_with_unchecked_overflow();
+            Can_not_subtract_with_checked_overflow();
             Can_modulus();
             Can_bit_or_1();
             Can_bit_and_1();
@@ -37,7 +37,7 @@ public int Run()
             Can_divide_bytes();
             Can_divide_signed_bytes();
             Can_sum_decimal_numbers();
-            Can_substract_decimal_numbers();
+            Can_subtract_decimal_numbers();
             Can_multiply_decimal_numbers();
             Can_divide_decimal_numbers();
             Can_divide_all_primitive_numeric_types_that_define_binary_operator_divide();
@@ -135,7 +135,7 @@ void AssertSub<T, R>(T x, T y, R expected, bool convertArgsToResult = false)
         }
 
 
-        public void Can_substract_all_primitive_numeric_types_that_define_binary_operator_substract()
+        public void Can_subtract_all_primitive_numeric_types_that_define_binary_operator_subtract()
         {
             AssertSub<byte, int>(5, 1, 4, true);
             AssertSub<sbyte, int>(5, 1, 4, true);
@@ -150,13 +150,13 @@ public void Can_substract_all_primitive_numeric_types_that_define_binary_operato
         }
 
 
-        public void Can_substract_with_unchecked_overflow()
+        public void Can_subtract_with_unchecked_overflow()
         {
             AssertSub<int, int>(int.MinValue, 1, int.MaxValue);
         }
 
 
-        public void Can_not_substract_with_checked_overflow()
+        public void Can_not_subtract_with_checked_overflow()
         {
             var a = Parameter(typeof(int), "a");
             var b = Parameter(typeof(int), "b");
@@ -385,7 +385,7 @@ public void Can_sum_decimal_numbers()
         }
 
 
-        public void Can_substract_decimal_numbers()
+        public void Can_subtract_decimal_numbers()
         {
             AssertSub(2.0m, 1.0m, 2.0m - 1.0m);
         }