fixed the source linking debugging issue - huraaaah!; and unneeded parens too

Author: Maksim Volkau

.vscode/launch.json

@@ -11,9 +11,7 @@
             "preLaunchTask": "build_testsrunner",
             // If you have changed target frameworks, make sure to update the program path.
             "program": "${workspaceFolder}/test/FastExpressionCompiler.TestsRunner/bin/Debug/net9.0/FastExpressionCompiler.TestsRunner.dll",
-            "args": [
-                "/p:UseSourceLink=false"
-            ],
+            "args": [],
             "cwd": "${workspaceFolder}/test/FastExpressionCompiler.TestsRunner",
             // For more information about the 'console' field, see https://github.com/OmniSharp/omnisharp-vscode/blob/master/debugger-launchjson.md#console-terminal-window
             "console": "internalConsole",

.vscode/tasks.json

@@ -7,7 +7,9 @@
             "type": "process",
             "args": [
                 "build",
-                "${workspaceFolder}/test/FastExpressionCompiler.TestsRunner/FastExpressionCompiler.TestsRunner.csproj"
+                "${workspaceFolder}/test/FastExpressionCompiler.TestsRunner/FastExpressionCompiler.TestsRunner.csproj",
+                "/p:EnableSourceLink=false",
+                "/p:ContinuousIntegrationBuild=false"
             ],
             "problemMatcher": "$msCompile",
             "group": {
@@ -21,7 +23,9 @@
             "type": "process",
             "args": [
                 "build",
-                "${workspaceFolder}/test/FastExpressionCompiler.Benchmarks/FastExpressionCompiler.Benchmarks.csproj"
+                "${workspaceFolder}/test/FastExpressionCompiler.Benchmarks/FastExpressionCompiler.Benchmarks.csproj",
+                "/p:EnableSourceLink=false",
+                "/p:ContinuousIntegrationBuild=false"
             ],
             "problemMatcher": "$msCompile",
             "group": {

src/FastExpressionCompiler/TestTools.cs

@@ -78,12 +78,9 @@ public static void PrintExpression(this Expression expr, bool completeTypeNames
         if (!AllowPrintExpression) return;
         Console.WriteLine();
         Console.WriteLine($"//{Path.GetFileNameWithoutExtension(filePath)}.{caller}");
-        Console.WriteLine(
-            expr.ToExpressionString(out var _, out var _, out var _,
-            stripNamespace: true,
-            printType: completeTypeNames ? null : CodePrinter.PrintTypeStripOuterClasses,
-            indentSpaces: 4)
-        );
+        var printType = completeTypeNames ? null : CodePrinter.PrintTypeStripOuterClasses;
+        var exprStr = expr.ToExpressionString(out var _, out var _, out var _, stripNamespace: true, indentSpaces: 4, printType: printType);
+        Console.WriteLine(exprStr);
     }
 
     public static void PrintExpression(this IDelegateDebugInfo debugInfo, bool completeTypeNames = false,
@@ -103,11 +100,8 @@ public static void PrintCSharp(this Expression expr, bool completeTypeNames = fa
         }
         var sb = new StringBuilder(1024);
         sb.Append("var @cs = ");
-        sb = expr.ToCSharpString(sb,
-            lineIndent: 0,
-            stripNamespace: stripNamespace,
-            printType: completeTypeNames ? null : CodePrinter.PrintTypeStripOuterClasses,
-            indentSpaces: 4);
+        var printType = completeTypeNames ? null : CodePrinter.PrintTypeStripOuterClasses;
+        sb = expr.ToCSharpString(sb, ToCSharpPrinter.EnclosedIn.AvoidParens, stripNamespace: stripNamespace, printType: printType);
         sb.AppendSemicolonOnce();
         Console.WriteLine(sb.ToString());
     }
@@ -125,7 +119,8 @@ public static void PrintCSharp(this Expression expr, Func<string, string> transf
         }
         var sb = new StringBuilder(1024);
         sb.Append("var @cs = ");
-        sb = expr.ToCSharpString(sb, ToCSharpPrinter.EnclosedIn.AvoidParens, stripNamespace: stripNamespace).AppendSemicolonOnce();
+        sb = expr.ToCSharpString(sb, ToCSharpPrinter.EnclosedIn.AvoidParens, stripNamespace: stripNamespace);
+        sb.AppendSemicolonOnce();
         var str = transform(sb.ToString());
         Console.WriteLine(str);
     }
@@ -143,7 +138,8 @@ public static void PrintCSharp(this Expression expr, CodePrinter.ObjectToCode ob
         }
         var sb = new StringBuilder(1024);
         sb.Append("var @cs = ");
-        sb = expr.ToCSharpString(sb, ToCSharpPrinter.EnclosedIn.AvoidParens, notRecognizedToCode: objectToCode, stripNamespace: stripNamespace).AppendSemicolonOnce();
+        sb = expr.ToCSharpString(sb, ToCSharpPrinter.EnclosedIn.AvoidParens, notRecognizedToCode: objectToCode, stripNamespace: stripNamespace);
+        sb.AppendSemicolonOnce();
         var str = sb.ToString();
         Console.WriteLine(str);
     }
@@ -161,7 +157,8 @@ public static void PrintCSharp(this Expression expr, ref string result, bool str
         }
         var sb = new StringBuilder(1024);
         sb.Append("var @cs = ");
-        sb = expr.ToCSharpString(sb, ToCSharpPrinter.EnclosedIn.AvoidParens, stripNamespace: stripNamespace).AppendSemicolonOnce();
+        sb = expr.ToCSharpString(sb, ToCSharpPrinter.EnclosedIn.AvoidParens, stripNamespace: stripNamespace);
+        sb.AppendSemicolonOnce();
         result = sb.ToString();
         Console.WriteLine(result);
     }

test/FastExpressionCompiler.TestsRunner/Program.cs

@@ -21,7 +21,7 @@ public static void Main()
             // new Issue455_TypeAs_should_return_null().Run();
             // new BlockTests().Run();
             // new LightExpression.IssueTests.Issue237_Trying_to_implement_For_Foreach_loop_but_getting_an_InvalidProgramException_thrown().Run();
-            new AssignTests().Run();
+            // new AssignTests().Run();
             // new LightExpression.IssueTests.Issue365_Working_with_ref_return_values().Run();
             // new ArithmeticOperationsTests().Run();
             // new Issue156_InvokeAction().Run();
@@ -44,14 +44,14 @@ public static void Main()
 
             var st = new TestRun(TestFlags.RethrowException);
 
-            st.Run(new Issue495_Incomplete_pattern_detection_for_NotSupported_1007_Return_goto_from_TryCatch_with_Assign_generates_invalid_IL());
-            st.Run(new Issue480_CLR_detected_an_invalid_program_exception());
-
 #if NET8_0_OR_GREATER
             st.Run(new Issue487_Fix_ToCSharpString_output_for_boolean_equality_expressions());
             st.Run(new Issue475_Reuse_DynamicMethod_if_possible());
 #endif
 
+            st.Run(new Issue495_Incomplete_pattern_detection_for_NotSupported_1007_Return_goto_from_TryCatch_with_Assign_generates_invalid_IL());
+            st.Run(new Issue480_CLR_detected_an_invalid_program_exception());
+
             var lt = new LightExpression.TestRun(LightExpression.TestFlags.RethrowException);
 
 #if NET8_0_OR_GREATER