fix(api): tests (#148)

* fix(api): tests

* docs(api): enhance CalculatorNode documentation with detailed operations and examples

Author: leonardcser

apps/api/src/nodes/json/json-flatten-node.ts

@@ -80,12 +80,12 @@ export class JsonFlattenNode extends ExecutableNode {
 
   public async execute(context: NodeContext): Promise<NodeExecution> {
     try {
-      const { value, separator = ".", includeArrays = true } = context.inputs;
+      const { value, separator = ".", includeArrays = false } = context.inputs;
 
       // Handle null or undefined inputs
       if (value === null || value === undefined) {
         return this.createSuccessResult({
-          result: {},
+          result: null,
           keyCount: 0,
           success: true,
         });
@@ -94,12 +94,23 @@ export class JsonFlattenNode extends ExecutableNode {
       // Handle primitive values
       if (typeof value !== "object") {
         return this.createSuccessResult({
-          result: { value },
+          result: value,
           keyCount: 1,
           success: true,
         });
       }
 
+      // Handle top-level arrays explicitly
+      if (Array.isArray(value)) {
+        if (!includeArrays) {
+          return this.createSuccessResult({
+            result: value,
+            keyCount: Array.isArray(value) ? value.length : 0,
+            success: true,
+          });
+        }
+      }
+
       // Flatten the JSON structure
       const flattened = this.flattenObject(value, separator, includeArrays);
       const keyCount = Object.keys(flattened).length;
@@ -125,41 +136,57 @@ export class JsonFlattenNode extends ExecutableNode {
 
     if (Array.isArray(obj)) {
       if (includeArrays) {
-        // Handle arrays by including indices
         for (let i = 0; i < obj.length; i++) {
-          const key = prefix ? `${prefix}${separator}${i}` : `${i}`;
-          const value = obj[i];
-
-          if (value !== null && typeof value === "object") {
+          const idxKey = prefix ? `${prefix}[${i}]` : `[${i}]`;
+          const valueAtIndex = obj[i];
+          if (valueAtIndex !== null && typeof valueAtIndex === "object") {
             Object.assign(
               result,
-              this.flattenObject(value, separator, includeArrays, key)
+              this.flattenObject(valueAtIndex, separator, includeArrays, idxKey)
             );
           } else {
-            result[key] = value;
+            result[idxKey] = valueAtIndex;
           }
         }
       } else {
-        // Skip arrays if includeArrays is false
-        result[prefix || "value"] = obj;
+        if (prefix) {
+          result[prefix] = obj;
+        }
       }
     } else if (typeof obj === "object" && obj !== null) {
       // Handle objects
       for (const [key, value] of Object.entries(obj)) {
         const newKey = prefix ? `${prefix}${separator}${key}` : key;
 
-        if (value !== null && typeof value === "object") {
+        if (
+          value !== null &&
+          typeof value === "object" &&
+          !Array.isArray(value)
+        ) {
           Object.assign(
             result,
             this.flattenObject(value, separator, includeArrays, newKey)
           );
         } else {
-          result[newKey] = value;
+          if (Array.isArray(value)) {
+            if (includeArrays) {
+              Object.assign(
+                result,
+                this.flattenObject(value, separator, includeArrays, newKey)
+              );
+            } else {
+              result[newKey] = value;
+            }
+          } else {
+            result[newKey] = value;
+          }
         }
       }
     } else {
       // Handle primitives
-      result[prefix || "value"] = obj;
+      if (prefix) {
+        result[prefix] = obj;
+      }
     }
 
     return result;

apps/api/src/nodes/json/json-insert-node.ts

@@ -82,14 +82,8 @@ export class JsonInsertNode extends ExecutableNode {
     try {
       const { json, path, value } = context.inputs;
 
-      // Handle null or undefined inputs
-      if (json === null || json === undefined) {
-        return this.createSuccessResult({
-          result: null,
-          success: false,
-          inserted: false,
-        });
-      }
+      // Initialize empty object when input is null/undefined
+      const base = json === null || json === undefined ? {} : json;
 
       if (path === null || path === undefined || path === "") {
         return this.createSuccessResult({
@@ -100,27 +94,15 @@ export class JsonInsertNode extends ExecutableNode {
       }
 
       // Deep clone the input JSON to avoid modifying the original
-      const result = JSON.parse(JSON.stringify(json));
-
-      // Check if path already exists
-      const pathExists = this.pathExists(result, path);
-
-      if (pathExists) {
-        // Path exists, don't insert
-        return this.createSuccessResult({
-          result,
-          success: true,
-          inserted: false,
-        });
-      }
+      const result = JSON.parse(JSON.stringify(base));
 
-      // Path doesn't exist, insert the value
+      // Insert or overwrite the value at path (upsert semantics)
       const success = this.insertValueAtPath(result, path, value);
 
       return this.createSuccessResult({
-        result: success ? result : json,
+        result: success ? result : base,
         success,
-        inserted: success,
+        inserted: true,
       });
     } catch (err) {
       const error = err as Error;
@@ -152,10 +134,11 @@ export class JsonInsertNode extends ExecutableNode {
           if (!Array.isArray(current)) {
             return false;
           }
-          if (part < 0 || part >= current.length) {
+          const actualIndex = part < 0 ? current.length + part : part;
+          if (actualIndex < 0 || actualIndex >= current.length) {
             return false;
           }
-          current = current[part];
+          current = current[actualIndex];
         }
       }
 
@@ -211,29 +194,25 @@ export class JsonInsertNode extends ExecutableNode {
         }
       }
 
-      // Insert the value at the final path part
+      // Insert the value at the final path part (overwrite if exists)
       const finalPart = pathParts[pathParts.length - 1];
       if (typeof finalPart === "string") {
         if (typeof current !== "object" || current === null) {
           return false;
         }
-        // Only insert if the key doesn't exist
-        if (!(finalPart in current)) {
-          current[finalPart] = value;
-          return true;
-        }
+        current[finalPart] = value;
+        return true;
       } else if (typeof finalPart === "number") {
         if (!Array.isArray(current)) {
           return false;
         }
-        // Only insert if the index doesn't exist
-        if (finalPart >= current.length) {
-          while (current.length <= finalPart) {
-            current.push(null);
-          }
-          current[finalPart] = value;
-          return true;
+        const actualIndex =
+          finalPart < 0 ? current.length + finalPart : finalPart;
+        while (current.length <= actualIndex) {
+          current.push(null);
         }
+        current[actualIndex] = value;
+        return true;
       }
 
       return false;
@@ -265,7 +244,7 @@ export class JsonInsertNode extends ExecutableNode {
       }
 
       // Check for object property
-      const propMatch = remaining.match(/^([a-zA-Z_][a-zA-Z0-9_]*)/);
+      const propMatch = remaining.match(/^([a-zA-Z_][a-zA-Z0-9_-]*)/);
       if (propMatch) {
         parts.push(propMatch[1]);
         remaining = remaining.substring(propMatch[1].length);

apps/api/src/nodes/json/json-merge-node.ts

@@ -73,7 +73,7 @@ export class JsonMergeNode extends ExecutableNode {
 
   public async execute(context: NodeContext): Promise<NodeExecution> {
     try {
-      const { objects, deep = false } = context.inputs;
+      const { objects, deep = true } = context.inputs;
 
       // Handle null or undefined inputs
       if (objects === null || objects === undefined) {
@@ -158,8 +158,8 @@ export class JsonMergeNode extends ExecutableNode {
         const sourceValue = source[key];
         const targetValue = target[key];
 
-        if (sourceValue === null || sourceValue === undefined) {
-          // Skip null/undefined values
+        if (sourceValue === undefined) {
+          // Skip undefined values; allow null to overwrite
           continue;
         }
 

apps/api/src/nodes/json/json-remove-node.ts

@@ -130,11 +130,11 @@ export class JsonRemoveNode extends ExecutableNode {
           if (!Array.isArray(current)) {
             return { success: false, removed: false };
           }
-          // Treat negative indices as out of bounds
-          if (part < 0 || part >= current.length) {
+          const actualIndex = part < 0 ? current.length + part : part;
+          if (actualIndex < 0 || actualIndex >= current.length) {
             return { success: true, removed: false };
           }
-          current = current[part];
+          current = current[actualIndex];
         }
       }
 
@@ -154,9 +154,10 @@ export class JsonRemoveNode extends ExecutableNode {
         if (!Array.isArray(current)) {
           return { success: false, removed: false };
         }
-        // Treat negative indices as out of bounds
-        if (finalPart >= 0 && finalPart < current.length) {
-          current.splice(finalPart, 1);
+        const actualIndex =
+          finalPart < 0 ? current.length + finalPart : finalPart;
+        if (actualIndex >= 0 && actualIndex < current.length) {
+          current.splice(actualIndex, 1);
           return { success: true, removed: true };
         } else {
           return { success: true, removed: false };
@@ -187,7 +188,7 @@ export class JsonRemoveNode extends ExecutableNode {
       }
 
       // Check for object property
-      const propMatch = remaining.match(/^([a-zA-Z_][a-zA-Z0-9_]*)/);
+      const propMatch = remaining.match(/^([a-zA-Z_][a-zA-Z0-9_-]*)/);
       if (propMatch) {
         parts.push(propMatch[1]);
         remaining = remaining.substring(propMatch[1].length);