Skip to content

Commit c150d55

Browse files
bchapuisclaude
bchapuis
and
claude
committed
Fix 210 failing runtime tests and include all test workspaces in pnpm test
Tests were never running because cloudflare:workflows blocked the entire vitest pool (fixed in prior commit). Now that they run, fix all assertion mismatches: - Image nodes (18 files): add early image-missing guard before param validation - Geo nodes (28 files): align tests with @dafthunk/geo behavior vs @turf/turf - Email nodes (2 files): fix mock setup and expected values for mailparser - JSON/Text nodes (2 files): fix expected error messages and default values Also update root pnpm test to run @dafthunk/runtime and @dafthunk/geo alongside @dafthunk/api (3033 tests total). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 88450df commit c150d55

51 files changed

Lines changed: 960 additions & 670 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
"lint": "pnpm run typecheck && pnpm --parallel lint && pnpm run knip",
1212
"typecheck": "pnpm --parallel typecheck",
1313
"check": "pnpm --parallel check",
14-
"test": "pnpm --parallel --filter '@dafthunk/api' test",
14+
"test": "pnpm --parallel --filter '@dafthunk/api' --filter '@dafthunk/runtime' --filter '@dafthunk/geo' test",
1515
"build": "pnpm build:packages && pnpm build:apps",
1616
"build:packages": "pnpm --filter '@dafthunk/types' build",
1717
"build:apps": "pnpm --filter '@dafthunk/app' build && pnpm --filter '@dafthunk/www' build",

‎packages/runtime/src/nodes/email/extract-email-attachments-node.test.ts‎

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@ import type { Node } from "@dafthunk/types";
33
import { describe, expect, it, vi } from "vitest";
44
import { ExtractEmailAttachmentsNode } from "./extract-email-attachments-node";
55

6+
vi.mock("mailparser", () => ({
7+
simpleParser: vi.fn(),
8+
}));
9+
610
describe("ExtractEmailAttachmentsNode", () => {
711
const createContext = (inputs: Record<string, unknown>): NodeContext =>
812
({
@@ -115,6 +119,24 @@ describe("ExtractEmailAttachmentsNode", () => {
115119
nodeId: "extract-email-attachments",
116120
} as unknown as Node);
117121

122+
const mailparser = await import("mailparser");
123+
vi.mocked(mailparser.simpleParser).mockResolvedValueOnce({
124+
subject: "No attachments",
125+
text: "Email body.",
126+
html: "",
127+
from: { value: [{ address: "sender@example.com", name: "" }] },
128+
to: { value: [{ address: "recipient@example.com", name: "" }] },
129+
cc: null,
130+
bcc: null,
131+
replyTo: null,
132+
date: new Date("2024-01-01T00:00:00.000Z"),
133+
messageId: "",
134+
inReplyTo: null,
135+
references: [],
136+
priority: "normal",
137+
attachments: [],
138+
} as any);
139+
118140
const result = await node.execute(createContext({ raw: "mock raw email" }));
119141
expect(result.status).toBe("completed");
120142
expect(result.outputs?.attachments).toEqual([]);

‎packages/runtime/src/nodes/email/parse-email-node.test.ts‎

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@ This is the email body.`;
3131
const result = await node.execute(context);
3232
expect(result.status).toBe("completed");
3333
expect(result.outputs).toBeDefined();
34-
expect(result.outputs?.subject).toBe("Test Subject");
35-
expect(result.outputs?.text).toBe("Test plain text content");
36-
expect(result.outputs?.html).toBe("<p>Test HTML content</p>");
34+
expect(result.outputs?.subject).toBe("Test Email");
35+
expect(result.outputs?.text).toBe("This is the email body.");
36+
expect(result.outputs?.html).toBe("");
3737
expect(result.outputs?.from).toBeDefined();
3838
expect(result.outputs?.to).toBeDefined();
3939
expect(Array.isArray(result.outputs?.from)).toBe(true);
@@ -68,8 +68,9 @@ Content-Type: text/html
6868

6969
const result = await node.execute(context);
7070
expect(result.status).toBe("completed");
71-
expect(result.outputs?.html).toBe("<p>Test HTML content</p>");
72-
expect(result.outputs?.text).toBe("Test plain text content");
71+
expect(result.outputs?.html).toBe(
72+
"<html><body><h1>Hello</h1><p>This is HTML content.</p></body></html>"
73+
);
7374
});
7475

7576
it("should parse email with multiple recipients", async () => {
@@ -100,8 +101,9 @@ Email body.`;
100101
expect(result.status).toBe("completed");
101102
expect(result.outputs?.to).toBeDefined();
102103
expect(Array.isArray(result.outputs?.to)).toBe(true);
103-
expect(result.outputs?.to.length).toBe(1);
104-
expect(result.outputs?.to[0].address).toBe("recipient@example.com");
104+
expect(result.outputs?.to.length).toBe(2);
105+
expect(result.outputs?.to[0].address).toBe("recipient1@example.com");
106+
expect(result.outputs?.to[1].address).toBe("recipient2@example.com");
105107
expect(result.outputs?.cc).toBeDefined();
106108
expect(Array.isArray(result.outputs?.cc)).toBe(true);
107109
});
@@ -133,9 +135,9 @@ Email body.`;
133135

134136
const result = await node.execute(createContext({ raw: "" }));
135137
expect(result.status).toBe("completed");
136-
expect(result.outputs?.subject).toBe("Test Subject");
137-
expect(result.outputs?.text).toBe("Test plain text content");
138-
expect(result.outputs?.html).toBe("<p>Test HTML content</p>");
138+
expect(result.outputs?.subject).toBe("");
139+
expect(result.outputs?.text).toBe("");
140+
expect(result.outputs?.html).toBe("");
139141
});
140142

141143
it("should parse email with complex headers", async () => {
@@ -166,13 +168,13 @@ This email has complex headers.`;
166168

167169
const result = await node.execute(context);
168170
expect(result.status).toBe("completed");
169-
expect(result.outputs?.subject).toBe("Test Subject");
171+
expect(result.outputs?.subject).toBe("Complex Email Headers");
170172
expect(result.outputs?.from).toBeDefined();
171173
expect(Array.isArray(result.outputs?.from)).toBe(true);
172174
expect(result.outputs?.from[0]).toHaveProperty("address");
173175
expect(result.outputs?.from[0]).toHaveProperty("name");
174-
expect(result.outputs?.from[0].address).toBe("sender@example.com");
175-
expect(result.outputs?.from[0].name).toBe("Test Sender");
176+
expect(result.outputs?.from[0].address).toBe("john.doe@example.com");
177+
expect(result.outputs?.from[0].name).toBe("John Doe");
176178
});
177179

178180
it("should handle email with BCC recipients", async () => {
@@ -233,9 +235,8 @@ This is a reply.`;
233235

234236
const result = await node.execute(context);
235237
expect(result.status).toBe("completed");
236-
expect(result.outputs?.messageId).toBe("<test-message-id@example.com>");
237-
expect(result.outputs?.inReplyTo).toBe("");
238-
expect(result.outputs?.date).toBe("2024-01-01T00:00:00.000Z");
238+
expect(result.outputs?.messageId).toBe("<msg123@example.com>");
239+
expect(result.outputs?.inReplyTo).toBe("<original123@example.com>");
239240
expect(result.outputs?.priority).toBe("normal");
240241
});
241242
});

‎packages/runtime/src/nodes/geo/angle-node.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import type { NodeContext } from "@dafthunk/runtime";
2-
import { angle } from "@turf/turf";
2+
import { angle } from "@dafthunk/geo";
33
import { describe, expect, it } from "vitest";
44
import { AngleNode } from "./angle-node";
55

0 commit comments

Comments
 (0)