Fix | Repo server concurrency fix (#431)

* Setting ephemeral helm working dir to false

* Added comment clarifying config loading order to values-override.yaml

Author: TBeijen

argocd-config/values-override.yaml

@@ -1,5 +1,13 @@
 # Overrides done by argocd-diff-preview
-# These will happen after the values.yaml file is loaded
+
+# This file is embedded by the argocd-diff-preview binary and will be loaded after the values.yaml file
+# If a values-override.yaml is placed in argocd-config directory when argocd-diff-preview runs,
+# contents will be loaded after this embedded config. Use with caution, if needing to override anything in this file
+#
+# Loading order:
+# - values.yaml            If present in argocd-config directory
+# - values-override.yaml   Embedded in argocd-diff-preview (this file)
+# - values-override.yaml   If present in argocd-config directory
 notifications:
   enabled: false
 dex:
@@ -29,6 +37,11 @@ repoServer:
     successThreshold: 1
     timeoutSeconds: 1
     failureThreshold: 40
+  # This prevents 'empty index.yaml' file corruption issues when multiple helm dependency build processes try to write the same index.yaml file
+  # Setting this to false disables the shared working dir
+  # Ref: https://github.com/argoproj/argo-cd/issues/12902
+  # Ref: https://github.com/helm/helm/issues/10735#issuecomment-1486058169
+  useEphemeralHelmWorkingDir: false
 controller:
   readinessProbe:
     initialDelaySeconds: 0