Skip to content

use dagger/node #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpenfound wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use dagger/node #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"name": "jest",
"engineVersion": "v0.20.1",
"engineVersion": "v0.20.3",
"sdk": {
"source": "github.com/vito/dang/dagger-sdk@352d057a4d4c4d77612104f842671b512495ef30"
"source": "dang"
Copy link
Copy Markdown
Contributor

@vito vito Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part's not quite ready for prime time - needs dagger/dagger#12830 first otherwise no checks are loaded (which is why this PR is ✔️)

Could be worth merging anyway and letting it magically un-break in the future when we ship a new engine, if this is all WIP, but yeah

Copy link
Copy Markdown
Contributor Author

@kpenfound kpenfound Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized this is "sdk": { "source": "dang" } instead of "sdk": "dang". Not sure how I messed that up because I did it at the same time as eslint and prettier. Since I merged the PR for eslint and prettier, would that mean the checks for those on the latest commit would be broken?

Copy link
Copy Markdown
Contributor

@vito vito Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sdk": { "source": "dang" } is technically correct and I think what dagger develop will spit back out

Since I merged the PR for eslint and prettier, would that mean the checks for those on the latest commit would be broken?

Yeah - the bug is that the native dang SDK doesn't support detecting @check, so check -l etc. will just be empty

Copy link
Copy Markdown
Contributor Author

@kpenfound kpenfound Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I probably ran develop on this one before pushing, that makes sense

},
"dependencies": [
{
"name": "node",
"source": "github.com/kpenfound/dag/node@main",
"pin": "9e6dad0e1e3a30afa82dd7e5663b5aa421cf25e7"
"source": "github.com/dagger/node@main",
"pin": "73da7e4e0169ff8075a43abfd54c7f63caf516a3"
}
]
}