chore(deps): update dependency sonaranalyzer.csharp to 10.25.0.139117 (#664)

* chore(deps): update dependency sonaranalyzer.csharp to 10.25.0.139117

* refactor: Refactor argument validation polyfills for .NET 8+

Reorganize and update ThrowIfInPast/ThrowIfInFuture overloads for DateOnly, DateTime, and DateTimeOffset. Move ThrowIfNullOrWhiteSpace under !NET8_0_OR_GREATER. Update XML docs to match new signatures and behaviors.

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Martin Stühmer <me@samtrion.net>

Author: renovate[bot]

Directory.Packages.props

@@ -15,7 +15,7 @@
     <GlobalPackageReference Include="Roslynator.CodeAnalysis.Analyzers" Version="4.15.0" />
     <GlobalPackageReference Include="Roslynator.CodeFixes" Version="4.15.0" />
     <GlobalPackageReference Include="Roslynator.Refactorings" Version="4.15.0" />
-    <GlobalPackageReference Include="SonarAnalyzer.CSharp" Version="10.23.0.137933" />
+    <GlobalPackageReference Include="SonarAnalyzer.CSharp" Version="10.25.0.139117" />
   </ItemGroup>
   <ItemGroup>
     <PackageVersion Include="Microsoft.Testing.Extensions.CodeCoverage" Version="18.6.2" />

src/NetEvolve.Arguments/ArgumentExceptionPolyfill.cs

@@ -34,31 +34,6 @@ public static void ThrowIfNullOrEmpty(
                 throw new ArgumentException("The value cannot be an empty string.", paramName);
             }
         }
-
-        /// <summary>Throws an exception if <paramref name="argument"/> is <see langword="null"/>, empty, or consists only of white-space characters.</summary>
-        /// <param name="argument">The string argument to validate.</param>
-        /// <param name="paramName">The name of the parameter with which <paramref name="argument"/> corresponds.</param>
-        /// <exception cref="ArgumentNullException"><paramref name="argument"/> is <see langword="null"/>.</exception>
-        /// <exception cref="ArgumentException"><paramref name="argument"/> is empty or consists only of white-space characters.</exception>
-        /// <seealso href="https://learn.microsoft.com/en-us/dotnet/api/system.argumentexception.throwifnullorwhitespace?view=net-10.0#system-argumentexception-throwifnullorwhitespace(system-string-system-string)" />
-        public static void ThrowIfNullOrWhiteSpace(
-            [NotNull] string? argument,
-            [CallerArgumentExpression(nameof(argument))] string? paramName = null
-        )
-        {
-            if (argument is null)
-            {
-                throw new ArgumentNullException(paramName);
-            }
-
-            if (string.IsNullOrWhiteSpace(argument))
-            {
-                throw new ArgumentException(
-                    "The value cannot be an empty string or composed entirely of whitespace.",
-                    paramName
-                );
-            }
-        }
 #endif
 
         /// <summary>Throws an exception if <paramref name="argument"/> is <see langword="null"/> or empty.</summary>
@@ -149,6 +124,33 @@ public static void ThrowIfNullOrEmpty<T>(
             }
         }
 
+#if !NET8_0_OR_GREATER
+        /// <summary>Throws an exception if <paramref name="argument"/> is <see langword="null"/>, empty, or consists only of white-space characters.</summary>
+        /// <param name="argument">The string argument to validate.</param>
+        /// <param name="paramName">The name of the parameter with which <paramref name="argument"/> corresponds.</param>
+        /// <exception cref="ArgumentNullException"><paramref name="argument"/> is <see langword="null"/>.</exception>
+        /// <exception cref="ArgumentException"><paramref name="argument"/> is empty or consists only of white-space characters.</exception>
+        /// <seealso href="https://learn.microsoft.com/en-us/dotnet/api/system.argumentexception.throwifnullorwhitespace?view=net-10.0#system-argumentexception-throwifnullorwhitespace(system-string-system-string)" />
+        public static void ThrowIfNullOrWhiteSpace(
+            [NotNull] string? argument,
+            [CallerArgumentExpression(nameof(argument))] string? paramName = null
+        )
+        {
+            if (argument is null)
+            {
+                throw new ArgumentNullException(paramName);
+            }
+
+            if (string.IsNullOrWhiteSpace(argument))
+            {
+                throw new ArgumentException(
+                    "The value cannot be an empty string or composed entirely of whitespace.",
+                    paramName
+                );
+            }
+        }
+#endif
+
         /// <summary>Throws an exception if <paramref name="argument"/> exceeds the specified maximum length.</summary>
         /// <param name="argument">The string argument to validate.</param>
         /// <param name="maxLength">The maximum allowed length.</param>

src/NetEvolve.Arguments/ArgumentOutOfRangeExceptionPolyfills.cs

@@ -358,62 +358,62 @@ public static void ThrowIfOutOfRange<T>(
         }
 
 #if NET8_0_OR_GREATER
-        /// <summary>Throws an <see cref="ArgumentOutOfRangeException"/> if <paramref name="value"/> is in the past relative to the current time.</summary>
-        /// <param name="value">The <see cref="DateTimeOffset"/> argument to validate as not in the past.</param>
-        /// <param name="timeProvider">The time provider to use for getting the current time. If <see langword="null"/>, <see cref="TimeProvider.System"/> is used.</param>
+        /// <summary>Throws an <see cref="ArgumentOutOfRangeException"/> if <paramref name="value"/> is in the past relative to the current date.</summary>
+        /// <param name="value">The <see cref="DateOnly"/> argument to validate as not in the past.</param>
+        /// <param name="timeProvider">The time provider to use for getting the current date. If <see langword="null"/>, <see cref="TimeProvider.System"/> is used.</param>
         /// <param name="paramName">The name of the parameter with which <paramref name="value"/> corresponds.</param>
         /// <exception cref="ArgumentOutOfRangeException"><paramref name="value"/> is in the past.</exception>
         public static void ThrowIfInPast(
-            DateTimeOffset value,
+            DateOnly value,
             TimeProvider? timeProvider = null,
             [Runtime.CompilerServices.CallerArgumentExpression(nameof(value))] string? paramName = null
         )
         {
-            var now = (timeProvider ?? TimeProvider.System).GetUtcNow();
-            if (value < now)
+            var today = DateOnly.FromDateTime((timeProvider ?? TimeProvider.System).GetUtcNow().UtcDateTime);
+            if (value < today)
             {
                 throw new ArgumentOutOfRangeException(
                     paramName,
                     value,
-                    $"Value must not be in the past. Current time: {now}."
+                    $"Value must not be in the past. Current date: {today}."
                 );
             }
         }
 
-        /// <summary>Throws an <see cref="ArgumentOutOfRangeException"/> if <paramref name="value"/> is in the future relative to the current time.</summary>
-        /// <param name="value">The <see cref="DateTimeOffset"/> argument to validate as not in the future.</param>
+        /// <summary>Throws an <see cref="ArgumentOutOfRangeException"/> if <paramref name="value"/> is in the past relative to the current time.</summary>
+        /// <param name="value">The <see cref="DateTime"/> argument to validate as not in the past.</param>
         /// <param name="timeProvider">The time provider to use for getting the current time. If <see langword="null"/>, <see cref="TimeProvider.System"/> is used.</param>
         /// <param name="paramName">The name of the parameter with which <paramref name="value"/> corresponds.</param>
-        /// <exception cref="ArgumentOutOfRangeException"><paramref name="value"/> is in the future.</exception>
-        public static void ThrowIfInFuture(
-            DateTimeOffset value,
+        /// <exception cref="ArgumentOutOfRangeException"><paramref name="value"/> is in the past.</exception>
+        public static void ThrowIfInPast(
+            DateTime value,
             TimeProvider? timeProvider = null,
             [Runtime.CompilerServices.CallerArgumentExpression(nameof(value))] string? paramName = null
         )
         {
-            var now = (timeProvider ?? TimeProvider.System).GetUtcNow();
-            if (value > now)
+            var now = (timeProvider ?? TimeProvider.System).GetUtcNow().UtcDateTime;
+            if (value < now)
             {
                 throw new ArgumentOutOfRangeException(
                     paramName,
                     value,
-                    $"Value must not be in the future. Current time: {now}."
+                    $"Value must not be in the past. Current time: {now}."
                 );
             }
         }
 
         /// <summary>Throws an <see cref="ArgumentOutOfRangeException"/> if <paramref name="value"/> is in the past relative to the current time.</summary>
-        /// <param name="value">The <see cref="DateTime"/> argument to validate as not in the past.</param>
+        /// <param name="value">The <see cref="DateTimeOffset"/> argument to validate as not in the past.</param>
         /// <param name="timeProvider">The time provider to use for getting the current time. If <see langword="null"/>, <see cref="TimeProvider.System"/> is used.</param>
         /// <param name="paramName">The name of the parameter with which <paramref name="value"/> corresponds.</param>
         /// <exception cref="ArgumentOutOfRangeException"><paramref name="value"/> is in the past.</exception>
         public static void ThrowIfInPast(
-            DateTime value,
+            DateTimeOffset value,
             TimeProvider? timeProvider = null,
             [Runtime.CompilerServices.CallerArgumentExpression(nameof(value))] string? paramName = null
         )
         {
-            var now = (timeProvider ?? TimeProvider.System).GetUtcNow().UtcDateTime;
+            var now = (timeProvider ?? TimeProvider.System).GetUtcNow();
             if (value < now)
             {
                 throw new ArgumentOutOfRangeException(
@@ -445,27 +445,25 @@ public static void ThrowIfInFuture(
                 );
             }
         }
-#endif
 
-#if NET8_0_OR_GREATER
-        /// <summary>Throws an <see cref="ArgumentOutOfRangeException"/> if <paramref name="value"/> is in the past relative to the current date.</summary>
-        /// <param name="value">The <see cref="DateOnly"/> argument to validate as not in the past.</param>
-        /// <param name="timeProvider">The time provider to use for getting the current date. If <see langword="null"/>, <see cref="TimeProvider.System"/> is used.</param>
+        /// <summary>Throws an <see cref="ArgumentOutOfRangeException"/> if <paramref name="value"/> is in the future relative to the current time.</summary>
+        /// <param name="value">The <see cref="DateTimeOffset"/> argument to validate as not in the future.</param>
+        /// <param name="timeProvider">The time provider to use for getting the current time. If <see langword="null"/>, <see cref="TimeProvider.System"/> is used.</param>
         /// <param name="paramName">The name of the parameter with which <paramref name="value"/> corresponds.</param>
-        /// <exception cref="ArgumentOutOfRangeException"><paramref name="value"/> is in the past.</exception>
-        public static void ThrowIfInPast(
-            DateOnly value,
+        /// <exception cref="ArgumentOutOfRangeException"><paramref name="value"/> is in the future.</exception>
+        public static void ThrowIfInFuture(
+            DateTimeOffset value,
             TimeProvider? timeProvider = null,
             [Runtime.CompilerServices.CallerArgumentExpression(nameof(value))] string? paramName = null
         )
         {
-            var today = DateOnly.FromDateTime((timeProvider ?? TimeProvider.System).GetUtcNow().UtcDateTime);
-            if (value < today)
+            var now = (timeProvider ?? TimeProvider.System).GetUtcNow();
+            if (value > now)
             {
                 throw new ArgumentOutOfRangeException(
                     paramName,
                     value,
-                    $"Value must not be in the past. Current date: {today}."
+                    $"Value must not be in the future. Current time: {now}."
                 );
             }
         }