feat(naming): add rules for static readonly fields capitalization and…#349
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA new .editorconfig naming rule was added to enforce PascalCase ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/NetEvolve.Defaults/configurations/template.editorconfig`:
- Around line 137-143: The new naming rule all_static_readonly enforces
PascalCase for static readonly fields and will warn for existing
underscore-prefixed names; rename all occurrences of static readonly fields such
as _ruleNED0001 and _ruleOLD0001 to PascalCase (e.g., RuleNED0001, RuleOLD0001),
update every reference/usages and any tests or reflection code that depend on
the old names, and ensure the symbols declared with the required_modifiers
static, readonly match the all_static_readonly naming_style to eliminate the
warnings from dotnet_naming_rule.all_static_readonly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 29d7e921-8741-4541-9f91-3fe717ca2370
📒 Files selected for processing (1)
src/NetEvolve.Defaults/configurations/template.editorconfig
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… severity
Summary by CodeRabbit
PascalCasenaming for static readonly fields. Violations will be reported as errors during code analysis.