Skip to content

Commit e9558b6

Browse files
chore(deps): update dependency netevolve.defaults to 2.6.0 (#465)
* chore(deps): update dependency netevolve.defaults to 2.6.0 * fix: Add analyzers, update config, and async test patterns - Add Meziantou and Roslynator analyzers/code fixes to central package management. - Update .editorconfig with static readonly naming rules, enable IDE0060, suppress RCS1163, and adjust code quality settings. - Remove redundant line from .gitattributes. - Update .gitignore for MemPalace and Beads/Dolt files. - Suppress additional analyzer warnings in test projects. - Refactor all test files to use .ConfigureAwait(false) for async calls. - Replace Guid.Parse with explicit Guid constructors for analyzer compliance. * refactor: Guid assertions for readability in tests Reformatted Guid constructor arguments and Assert.That chains in test methods to improve code readability. No changes to logic or test behavior. --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Martin Stühmer <me@samtrion.net>
1 parent f0625d6 commit e9558b6

10 files changed

Lines changed: 230 additions & 169 deletions

.editorconfig

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,13 @@ dotnet_naming_rule.all_const.severity = error
134134
dotnet_naming_rule.all_const.style = all_elements
135135
dotnet_naming_rule.all_const.symbols = all_const
136136

137+
dotnet_naming_style.all_static_readonly.capitalization = pascal_case
138+
dotnet_naming_symbols.all_static_readonly.applicable_kinds = field
139+
dotnet_naming_symbols.all_static_readonly.required_modifiers = static, readonly
140+
dotnet_naming_rule.all_static_readonly.severity = error
141+
dotnet_naming_rule.all_static_readonly.style = all_static_readonly
142+
dotnet_naming_rule.all_static_readonly.symbols = all_static_readonly
143+
137144
dotnet_naming_style.all_fields.required_prefix = _
138145
dotnet_naming_style.all_fields.capitalization = camel_case
139146
dotnet_naming_symbols.all_fields.applicable_kinds = field
@@ -263,6 +270,11 @@ dotnet_diagnostic.IDE0046.severity = sugges
263270
csharp_style_prefer_primary_constructors = false
264271
dotnet_diagnostic.IDE0290.severity = suggestion
265272

273+
# IDE0060: Remove unused parameter
274+
dotnet_diagnostic.IDE0060.severity = warning
275+
dotnet_diagnostic.RCS1163.severity = none
276+
dotnet_code_quality_unused_parameters = all
277+
266278
# [CSharpier] Incompatible rules deactivated
267279
# https://csharpier.com/docs/IntegratingWithLinters#code-analysis-rules
268280
dotnet_diagnostic.IDE0055.severity = none

.gitattributes

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
* text=auto eol=lf
2-
* text eol=lf
32

43
# (binary is a macro for -text -diff)
54
*.png binary

.gitignore

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,3 +364,13 @@ MigrationBackup/
364364
# Prevent nested .editorconfig files - only root .editorconfig should be used
365365
**/.editorconfig
366366
!/.editorconfig
367+
368+
# MemPalace per-project files
369+
.mempalace/
370+
mempalace.yaml
371+
entities.json
372+
373+
# Beads / Dolt files (added by bd init)
374+
.dolt/
375+
*.db
376+
.beads-credential-key

Directory.Packages.props

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,17 @@
55
</PropertyGroup>
66
<ItemGroup>
77
<GlobalPackageReference Include="CSharpier.MSBuild" Version="1.2.6" />
8+
<GlobalPackageReference Include="Meziantou.Analyzer" Version="3.0.77" />
89
<GlobalPackageReference Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="4.14.0" />
910
<GlobalPackageReference Include="Microsoft.CodeAnalysis.NetAnalyzers" Version="10.0.203" />
1011
<GlobalPackageReference Include="Microsoft.SourceLink.GitHub" Version="10.0.203" />
1112
<GlobalPackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15" />
12-
<GlobalPackageReference Include="NetEvolve.Defaults" Version="2.3.1" />
13+
<GlobalPackageReference Include="NetEvolve.Defaults" Version="2.6.0" />
14+
<GlobalPackageReference Include="Roslynator.Analyzers" Version="4.15.0" />
15+
<GlobalPackageReference Include="Roslynator.Formatting.Analyzers" Version="4.15.0" />
16+
<GlobalPackageReference Include="Roslynator.CodeAnalysis.Analyzers" Version="4.15.0" />
17+
<GlobalPackageReference Include="Roslynator.CodeFixes" Version="4.15.0" />
18+
<GlobalPackageReference Include="Roslynator.Refactorings" Version="4.15.0" />
1319
<GlobalPackageReference Include="SonarAnalyzer.CSharp" Version="10.25.0.139117" />
1420
</ItemGroup>
1521
<ItemGroup>

tests/NetEvolve.Extensions.Data.Tests.Integration/DbDataReaderExtensionsIntegrationTests.cs

Lines changed: 71 additions & 63 deletions
Large diffs are not rendered by default.

tests/NetEvolve.Extensions.Data.Tests.Integration/IDataReaderExtensionsIntegrationTests.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public async Task HasColumn_ExistingColumns_ReturnsTrue()
6161
{
6262
using var command = _connection.CreateCommand();
6363
command.CommandText = "SELECT * FROM TestTable";
64-
using var reader = await command.ExecuteReaderAsync();
64+
using var reader = await command.ExecuteReaderAsync().ConfigureAwait(false);
6565

6666
var hasId = reader.HasColumn("Id");
6767
var hasName = reader.HasColumn("Name");
@@ -87,7 +87,7 @@ public async Task HasColumn_NonExistingColumns_ReturnsFalse()
8787
{
8888
using var command = _connection.CreateCommand();
8989
command.CommandText = "SELECT * FROM TestTable";
90-
using var reader = await command.ExecuteReaderAsync();
90+
using var reader = await command.ExecuteReaderAsync().ConfigureAwait(false);
9191

9292
var hasNonExistent = reader.HasColumn("NonExistentColumn");
9393
var hasWrongCase = reader.HasColumn("WRONGCASE");
@@ -104,7 +104,7 @@ public async Task HasColumn_CaseInsensitiveMatching_ReturnsTrue()
104104
{
105105
using var command = _connection.CreateCommand();
106106
command.CommandText = "SELECT * FROM TestTable";
107-
using var reader = await command.ExecuteReaderAsync();
107+
using var reader = await command.ExecuteReaderAsync().ConfigureAwait(false);
108108

109109
var hasIdLowercase = reader.HasColumn("id");
110110
var hasNameUppercase = reader.HasColumn("NAME");
@@ -123,7 +123,7 @@ public async Task HasColumn_SubsetOfSelectedColumns_ReturnsCorrectResults()
123123
{
124124
using var command = _connection.CreateCommand();
125125
command.CommandText = "SELECT Id, Name, Email FROM TestTable";
126-
using var reader = await command.ExecuteReaderAsync();
126+
using var reader = await command.ExecuteReaderAsync().ConfigureAwait(false);
127127

128128
var hasId = reader.HasColumn("Id");
129129
var hasName = reader.HasColumn("Name");
@@ -146,7 +146,7 @@ public async Task HasColumn_AliasedColumns_ReturnsCorrectResults()
146146
{
147147
using var command = _connection.CreateCommand();
148148
command.CommandText = "SELECT Id AS UserId, Name AS FullName FROM TestTable";
149-
using var reader = await command.ExecuteReaderAsync();
149+
using var reader = await command.ExecuteReaderAsync().ConfigureAwait(false);
150150

151151
var hasUserId = reader.HasColumn("UserId");
152152
var hasFullName = reader.HasColumn("FullName");
@@ -167,7 +167,7 @@ public async Task HasColumn_ComputedColumns_ReturnsCorrectResults()
167167
{
168168
using var command = _connection.CreateCommand();
169169
command.CommandText = "SELECT COUNT(*) AS TotalCount, MAX(Age) AS MaxAge FROM TestTable";
170-
using var reader = await command.ExecuteReaderAsync();
170+
using var reader = await command.ExecuteReaderAsync().ConfigureAwait(false);
171171

172172
var hasTotalCount = reader.HasColumn("TotalCount");
173173
var hasMaxAge = reader.HasColumn("MaxAge");
@@ -192,7 +192,7 @@ public async Task HasColumn_ValidColumnNames_ReturnsTrue(string columnName)
192192
{
193193
using var command = _connection.CreateCommand();
194194
command.CommandText = "SELECT * FROM TestTable";
195-
using var reader = await command.ExecuteReaderAsync();
195+
using var reader = await command.ExecuteReaderAsync().ConfigureAwait(false);
196196

197197
var hasColumn = reader.HasColumn(columnName);
198198

@@ -207,7 +207,7 @@ public async Task HasColumn_InvalidColumnNames_ReturnsFalse(string columnName)
207207
{
208208
using var command = _connection.CreateCommand();
209209
command.CommandText = "SELECT * FROM TestTable";
210-
using var reader = await command.ExecuteReaderAsync();
210+
using var reader = await command.ExecuteReaderAsync().ConfigureAwait(false);
211211

212212
var hasColumn = reader.HasColumn(columnName);
213213

0 commit comments

Comments
 (0)