audit: phase 2 verification U11-U15 (round 01)#521
Closed
samtrion wants to merge 1 commit into
Closed
Conversation
Independently verify usability assumptions U11 through U15 with file:line evidence and failing tests / repros (TUnit + PowerShell). | ID | Status | Failing artifact | |-----|---------------|--------------------------------------------------------------------------------------------| | U11 | CONFIRMED | tests/NetEvolve.Pulse.Tests.Unit/Outbox/TransportOverwriteDiagnosticTests.cs | | U12 | CONFIRMED | tests/NetEvolve.Pulse.Tests.Unit/IMediatorSendOnlyBackgroundServiceLifetimeTests.cs | | U13 | NEEDS-NUANCE | audit/repros/u13/verify.ps1 (icon missing; readme auto-detected on .NET SDK 10.x) | | U14 | CONFIRMED | audit/repros/u14/verify.ps1 (fails with NETSDK1045, not CS1003/CS8400 as predicted) | | U15 | CONFIRMED | tests/NetEvolve.Pulse.Tests.Unit/MissingHandlerDiagnosticTests.cs | Tests/repros compile (dotnet build NetEvolve.Pulse.Tests.Unit.csproj: 0 errors). No production code changes — Phase 3 will own the fixes. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Independent Phase 2 verification of usability assumptions U11 through U15 from
audit/assumptions/round-01-usability.md. Each assumption was re-evaluated against the worktree's current source, and a failing test or repro was produced where applicable.This PR contains NO production code changes — Phase 3 builders will fix the issues. Failing tests + Notes only.
tests/NetEvolve.Pulse.Tests.Unit/Outbox/TransportOverwriteDiagnosticTests.csIMediatorScoped —BackgroundServiceXML-doc example violates DI lifetimetests/NetEvolve.Pulse.Tests.Unit/IMediatorSendOnlyBackgroundServiceLifetimeTests.csaudit/repros/u13/verify.ps1(+ committed nuspec evidence). README auto-detected on .NET 10 SDK; icon still missing.extension(...)blocks lock source build to .NET 10 SDKaudit/repros/u14/verify.ps1(+ committedbuild.log). Actual error:NETSDK1045, notCS1003/CS8400.tests/NetEvolve.Pulse.Tests.Unit/MissingHandlerDiagnosticTests.csNotable findings beyond the original assumptions
.NET 10 SDK(10.0.300) auto-detects an adjacentREADME.mdand emits<readme>README.md</readme>in the nuspec without any explicitPackageReadmeFileproperty. The icon half (<icon>+logo.pngpacking) is still fully missing. Phase 3 should still set both properties explicitly to avoid behavior drifting with SDK version.NETSDK1045(cannot targetnet9.0), surfaced before the compiler runs. The original assumption predictedCS1003/CS8400parser errors on theextension(...)syntax — those would only appear if the multi-target was reduced tonet8.0only.UseAzureServiceBusTransport_replaces_existing_transport(line 116-126 ofAzureServiceBusExtensionsTests.cs) codifies the U11 footgun as if it were correct behavior. Phase 3 should reconsider.Test plan
dotnet build tests/NetEvolve.Pulse.Tests.Unit/NetEvolve.Pulse.Tests.Unit.csproj— 0 errors (12 style warnings only).pwsh audit/repros/u13/verify.ps1— must exit 0 after fix.pwsh audit/repros/u14/verify.ps1— must exit 0 after fix (i.e., build succeeds with .NET 8 SDK pinned).🤖 Generated with Claude Code