audit: phase 2 verification Q01-Q06 (round 01)#523
Closed
samtrion wants to merge 1 commit into
Closed
Conversation
Verifies the first six quality assumptions from
audit/assumptions/round-01-quality.md with fresh file:line evidence and
adds one failing TUnit test per CONFIRMED defect.
Status tally:
- Q01 OutboxProcessorHostedService captive-dependency CONFIRMED
- Q02 Stuck Processing rows never reaped CONFIRMED
- Q03 OutboxProcessor bypasses TimeProvider CONFIRMED (blocked-by-API)
- Q04 IdempotencyCommandInterceptor check-then-act race CONFIRMED
- Q05 ConcurrentCommandGuard dispose race + GetOrAdd leak NEEDS-NUANCE
- Q06 KafkaMessageTransport ignores CancellationToken CONFIRMED
Each failing test is tagged with [TestGroup("Audit-Q##")] so Phase 3
builders can target them. Tests intentionally fail today; do not fix
them in this commit.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of the NetEvolve.Pulse audit. Independently verifies the first six quality
assumptions raised in
audit/assumptions/round-01-quality.mdand ships one failingTUnit test per CONFIRMED defect.
Status table
SingletonScopedCaptiveDependencyTests.csStatus=Processingrows never reapedStuckProcessingMessagesReaperTests.csTimeProviderOutboxProcessorTimeProviderTests.csIdempotencyCommandInterceptoris check-then-act, not atomicIdempotencyConcurrentRaceTests.csConcurrentCommandGuardInterceptordispose race + GetOrAdd factory leakConcurrentCommandGuardDisposeRaceTests.cs(dispose-race only)KafkaMessageTransportignores CancellationToken on Flush/IsHealthyKafkaMessageTransportCancellationTests.csSix new tests, six new verification documents in
audit/verification/.All tests compile against the public API on net8.0/net9.0/net10.0 (verified via
dotnet build).The Q03 test is intentionally a reflection-based contract test because the public constructor does
not yet accept a
TimeProvider(blocked-by-API).Phase 3 builders should fix the underlying defects in a follow-up PR; this PR intentionally leaves
the failing tests in place.
Test plan
dotnet build tests/NetEvolve.Pulse.Tests.Unit/NetEvolve.Pulse.Tests.Unit.csprojsucceeds on net8.0, net9.0, net10.0 (already verified locally)