fix: new round of ts-strict fixes (#5870)

rebelchris · web-flow · commit 26cbf62985c8 · 2026-04-16T10:10:20.000+02:00
diff --git a/packages/webapp/components/KeywordManagement.spec.tsx b/packages/webapp/components/KeywordManagement.spec.tsx
@@ -11,6 +11,7 @@ import {
 import type { FeedData } from '@dailydotdev/shared/src/graphql/feed';
 import { KEYWORD_FEED_QUERY } from '@dailydotdev/shared/src/graphql/feed';
 import type { Post } from '@dailydotdev/shared/src/graphql/posts';
+import { PostType } from '@dailydotdev/shared/src/graphql/posts';
 import type { Connection } from '@dailydotdev/shared/src/graphql/common';
 import type { MockedGraphQLResponse } from '@dailydotdev/shared/__tests__/helpers/graphql';
 import { mockGraphQL } from '@dailydotdev/shared/__tests__/helpers/graphql';
@@ -39,6 +40,7 @@ const defaultFeedPage: Connection<Post> = {
       node: {
         id: '0e4005b2d3cf191f8c44c2718a457a1e',
         title: 'Learn SQL',
+        type: PostType.Article,
         image:
           'https://media.daily.dev/image/upload/f_auto,q_auto/v1/posts/22fc3ac5cc3fedf281b6e4b46e8c0ba2',
         commentsPermalink: 'https://localhost:5002/posts/9CuRpr5NiEY5',
diff --git a/packages/webapp/components/PostSEOSchema.tsx b/packages/webapp/components/PostSEOSchema.tsx
@@ -367,7 +367,7 @@ export interface PostSEOSchemaProps {
 export const PostSEOSchema = ({
   post,
   topComments,
-}: PostSEOSchemaProps): ReactElement => {
+}: PostSEOSchemaProps): ReactElement | null => {
   if (!post) {
     return null;
   }
diff --git a/packages/webapp/components/ProtectedPage.spec.tsx b/packages/webapp/components/ProtectedPage.spec.tsx
@@ -22,7 +22,7 @@ describe('ProtectedPage', () => {
     render(
       <AuthContext.Provider
         value={{
-          user: null,
+          user: undefined,
           isAuthReady: true,
           isFetched: true,
           isLoggedIn: false,
diff --git a/packages/webapp/components/footer/FooterPlusButton.tsx b/packages/webapp/components/footer/FooterPlusButton.tsx
@@ -48,7 +48,7 @@ export function FooterPlusButton({
   className,
 }: FooterPlusButtonProps): ReactElement {
   const { user } = useAuthContext();
-  const drawerRef = useRef<DrawerRef>();
+  const drawerRef = useRef<DrawerRef>(null);
   const [isDrawerOpen, setIsDrawerOpen] = useState(false);
   const props = user
     ? { onClick: () => setIsDrawerOpen(true) }
diff --git a/packages/webapp/components/footer/common.ts b/packages/webapp/components/footer/common.ts
@@ -18,8 +18,12 @@ export interface FooterNavBarContainerProps {
 export const getNavPath = (
   path: FooterTab['path'],
   user: LoggedUser,
-): string => {
-  return typeof path === 'string' ? path : path(user);
+): string | undefined => {
+  if (typeof path === 'string') {
+    return path;
+  }
+
+  return path?.(user);
 };
 
 export const blurClasses = 'bg-blur-baseline backdrop-blur-[2.5rem]';
diff --git a/packages/webapp/components/history/reading.tsx b/packages/webapp/components/history/reading.tsx
@@ -67,7 +67,7 @@ export function ReadingHistory(): ReactElement {
       />
       {hasData && (
         <ReadingHistoryList
-          data={data}
+          data={data!}
           onHide={hideReadHistory}
           infiniteScrollRef={infiniteScrollRef}
         />
diff --git a/packages/webapp/components/invite/Referral.tsx b/packages/webapp/components/invite/Referral.tsx
@@ -42,7 +42,7 @@ export function Referral({
 
   useEffect(() => {
     if (isLoggedIn) {
-      router.push(redirectTo);
+      router.push(redirectTo ?? '/');
     }
 
     // router is an unstable dependency
diff --git a/packages/webapp/components/layouts/CoresLayout.tsx b/packages/webapp/components/layouts/CoresLayout.tsx
@@ -20,7 +20,7 @@ import type { MainFeedPageProps } from './MainFeedPage';
 
 export default function CoresLayout({
   children,
-}: MainFeedPageProps): ReactElement {
+}: MainFeedPageProps): ReactElement | null {
   const isMobile = useViewSizeClient(ViewSize.MobileL);
   const { back, replace, push, isReady } = useRouter();
   const { user, isAuthReady } = useAuthContext();
diff --git a/packages/webapp/components/layouts/MainFeedPage.tsx b/packages/webapp/components/layouts/MainFeedPage.tsx
@@ -73,7 +73,7 @@ export default function MainFeedPage({
   const [feedName, setFeedName] = useState(
     getInternalFeedName(router?.pathname, { isMyFeed: isMyFeedURL }),
   );
-  const [isSearchOn, setIsSearchOn] = useState(isFinderPage);
+  const [isSearchOn, setIsSearchOn] = useState(!!isFinderPage);
   useEffect(() => {
     const isMyFeed = router?.pathname === '/my-feed';
     if (getShouldRedirect(isMyFeed, !!user)) {
diff --git a/packages/webapp/components/layouts/PlusLayout/PlusHeader.tsx b/packages/webapp/components/layouts/PlusLayout/PlusHeader.tsx
@@ -10,7 +10,7 @@ import { webappUrl } from '@dailydotdev/shared/src/lib/constants';
 import { LogoWithPlus } from '@dailydotdev/shared/src/components/Logo';
 import { useViewSize, ViewSize } from '@dailydotdev/shared/src/hooks';
 
-export const PlusHeader = (): ReactElement => {
+export const PlusHeader = (): ReactElement | null => {
   const isMobile = useViewSize(ViewSize.MobileL);
   const { back, replace, isReady } = useRouter();
 
diff --git a/packages/webapp/components/layouts/PlusLayout/PlusLayout.tsx b/packages/webapp/components/layouts/PlusLayout/PlusLayout.tsx
@@ -15,7 +15,7 @@ import { PlusHeader } from './PlusHeader';
 
 export default function PlusLayout({
   children,
-}: MainFeedPageProps): ReactElement {
+}: MainFeedPageProps): ReactElement | null {
   const { user, isAuthReady } = useAuthContext();
   const { growthbook } = useGrowthBookContext();
   const router = useRouter();
diff --git a/packages/webapp/components/layouts/SettingsLayout/Customization/DevCard/DevCardStep1.tsx b/packages/webapp/components/layouts/SettingsLayout/Customization/DevCard/DevCardStep1.tsx
@@ -39,7 +39,7 @@ export const DevCardStep1 = ({ onGenerateImage }: Step1Props): ReactElement => {
 
   return (
     <div className="flex flex-col items-center">
-      <DevCardPlaceholder profileImage={user.image} />
+      <DevCardPlaceholder profileImage={user!.image} />
       <Typography bold tag={TypographyTag.H1} type={TypographyType.Title1}>
         Generate your DevCard
       </Typography>
diff --git a/packages/webapp/components/layouts/SettingsLayout/FeedSettingsLayout.tsx b/packages/webapp/components/layouts/SettingsLayout/FeedSettingsLayout.tsx
@@ -9,7 +9,7 @@ import { getSettingsLayout } from '.';
 export const FeedSettingsLayout = ({ children }: PropsWithChildren) => {
   const { user } = useAuthContext();
   const feedSettingsEditContext = useFeedSettingsEdit({
-    feedSlugOrId: user.id,
+    feedSlugOrId: user!.id,
   });
   return (
     <FeedSettingsEditContext.Provider value={feedSettingsEditContext}>
diff --git a/packages/webapp/components/layouts/SettingsLayout/Security/AccountLoginSection.tsx b/packages/webapp/components/layouts/SettingsLayout/Security/AccountLoginSection.tsx
@@ -42,7 +42,7 @@ function AccountLoginSection({
   children,
   className,
   buttonVariant = ButtonVariant.Primary,
-}: AccountLoginSectionProps): ReactElement {
+}: AccountLoginSectionProps): ReactElement | null {
   if (!providers?.length) {
     return null;
   }
diff --git a/packages/webapp/components/layouts/SettingsLayout/common.tsx b/packages/webapp/components/layouts/SettingsLayout/common.tsx
@@ -43,7 +43,7 @@ export const CommonTextField = classed(TextField, { container: 'max-w-sm' });
 export const AccountTextField = classed(CommonTextField, { container: 'mt-6' });
 
 type SettingsSwitchProps = {
-  name?: string;
+  name: string;
   children: ReactNode;
   checked: boolean;
   onToggle: () => void;
diff --git a/packages/webapp/hooks/useWebappVersion.ts b/packages/webapp/hooks/useWebappVersion.ts
@@ -16,7 +16,7 @@ const getVersion = (query: ParsedUrlQuery): string | undefined => {
   return undefined;
 };
 
-export default function useWebappVersion(): string {
+export default function useWebappVersion(): string | undefined {
   const { query } = useRouter();
   const [version, setVersion] = useState<string>();
 
diff --git a/packages/webapp/lib/gameCenter.spec.ts b/packages/webapp/lib/gameCenter.spec.ts
@@ -77,6 +77,7 @@ describe('game center helpers', () => {
         xpInLevel: 150,
         xpToNextLevel: 250,
       },
+      hasNewQuestRotations: false,
       currentStreak: 4,
       longestStreak: 9,
       daily: {
diff --git a/packages/webapp/pages/agents/ask/index.tsx b/packages/webapp/pages/agents/ask/index.tsx
@@ -169,7 +169,7 @@ const AskPage = (): ReactElement => {
                 color={ButtonColor.Avocado}
                 size={ButtonSize.Large}
                 icon={<DevPlusIcon />}
-                onClick={(e) => {
+                onClick={(e: React.MouseEvent) => {
                   if (!isLoggedIn) {
                     e.preventDefault();
                     showLogin({ trigger: AuthTriggers.Plus });
diff --git a/packages/webapp/pages/settings/api.tsx b/packages/webapp/pages/settings/api.tsx
@@ -673,7 +673,7 @@ const ApiAccessPage = (): ReactElement => {
                             multiline={method.multilineCode}
                             onCopy={() =>
                               handleCopy(
-                                method.copyValue,
+                                method.copyValue!,
                                 method.copySuccessMessage,
                               )
                             }
diff --git a/packages/webapp/pages/settings/customization/devcard.tsx b/packages/webapp/pages/settings/customization/devcard.tsx
@@ -39,7 +39,7 @@ const seo: NextSeoProps = {
   },
 };
 
-const Page = (): ReactElement => {
+const Page = (): ReactElement | null => {
   const { completeAction, checkHasCompleted, isActionsFetched } = useActions();
   const { user, loadingUser } = useAuthContext();
   const isDevCardGenerated = checkHasCompleted(ActionType.DevCardGenerate);
diff --git a/packages/webapp/pages/settings/customization/gamification.tsx b/packages/webapp/pages/settings/customization/gamification.tsx
@@ -16,7 +16,7 @@ import { defaultSeo } from '../../../next-seo';
 import { getTemplatedTitle } from '../../../components/layouts/utils';
 import { SettingsSwitch } from '../../../components/layouts/SettingsLayout/common';
 
-const GamificationSettingsPage = (): ReactElement => {
+const GamificationSettingsPage = (): ReactElement | null => {
   const router = useRouter();
   const {
     optOutLevelSystem,
diff --git a/packages/webapp/pages/settings/privacy.tsx b/packages/webapp/pages/settings/privacy.tsx
@@ -28,7 +28,7 @@ const seo: NextSeoProps = {
   ...getPageSeoTitles('Privacy'),
 };
 
-const AccountInvitePage = (): ReactElement => {
+const AccountInvitePage = (): ReactElement | null => {
   const router = useRouter();
   const { saveCookies } = useConsentCookie(GdprConsentKey.Marketing);
   const { user, isAuthReady, isGdprCovered } = useAuthContext();
diff --git a/packages/webapp/pages/squads/discover/my.tsx b/packages/webapp/pages/squads/discover/my.tsx
@@ -25,7 +25,7 @@ import { mainFeedLayoutProps } from '../../../components/layouts/MainFeedPage';
 import { SquadDirectoryLayout } from '../../../../shared/src/components/squads/layout/SquadDirectoryLayout';
 import { defaultSeo } from '../../../next-seo';
 
-function MySquadsPage(): ReactElement {
+function MySquadsPage(): ReactElement | null {
   const { count, isModeratorInAnySquad } = useSquadPendingPosts();
   const { squads } = useAuthContext();
   const router = useRouter();
diff --git a/packages/webapp/pages/squads/new.tsx b/packages/webapp/pages/squads/new.tsx
@@ -50,7 +50,7 @@ const NewSquad = (): ReactElement => {
         await onSave({
           channelId: selectedChannel,
           integrationId,
-          sourceId: squad.id,
+          sourceId: squad.id!,
         });
       }
 

Original file line number	Diff line number	Diff line change
`@@ -367,7 +367,7 @@ export interface PostSEOSchemaProps {`
`367`	`367`	`export const PostSEOSchema = ({`
`368`	`368`	`post,`
`369`	`369`	`topComments,`
`370`		`-}: PostSEOSchemaProps): ReactElement => {`
	`370`	`+}: PostSEOSchemaProps): ReactElement \| null => {`
`371`	`371`	`if (!post) {`
`372`	`372`	`return null;`
`373`	`373`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ export function Referral({`
`42`	`42`
`43`	`43`	`useEffect(() => {`
`44`	`44`	`if (isLoggedIn) {`
`45`		`- router.push(redirectTo);`
	`45`	`+ router.push(redirectTo ?? '/');`
`46`	`46`	`}`
`47`	`47`
`48`	`48`	`// router is an unstable dependency`