Skip to content

Commit 434f40a

Browse files
Merge branch 'main' into experiment-onestop-composer
2 parents 7cc7df1 + 5b9cc61 commit 434f40a

7 files changed

Lines changed: 50 additions & 6 deletions

File tree

packages/shared/src/features/hackathon/components/HackathonHero.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export const HackathonHero = (): ReactElement => {
2828
</Typography>
2929
</FlexRow>
3030
<img
31-
src={fromCDN('/assets/hackathon-og.png')}
31+
src={fromCDN('/assets/hackathon-og.png?v=2')}
3232
alt="daily.dev Hackathon"
3333
className="w-full max-w-2xl rounded-16"
3434
/>

packages/shared/src/features/hackathon/components/HackathonHowItWorks.tsx

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,13 @@ export const HackathonHowItWorks = (): ReactElement => {
4545
daily.dev Plus
4646
</a>
4747
</Link>{' '}
48-
with all the benefits for best submissions. Winning projects featured
49-
on daily.dev and social media.
48+
with all the benefits for best submissions.{' '}
49+
<Link href="https://www.coderabbit.ai/pricing">
50+
<a target="_blank" className="text-[#FF570A] underline">
51+
3 free months of CodeRabbit Pro Plus.
52+
</a>
53+
</Link>{' '}
54+
Winning projects featured on daily.dev and social media.
5055
</Typography>
5156
</FlexCol>
5257

packages/shared/src/features/onboarding/steps/FunnelOrganicSignup.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ export const FunnelOrganicSignup = withIsActiveGuard(
7878
const [authDisplay, setAuthDisplay] = useState(
7979
AuthDisplay.OnboardingSignup,
8080
);
81-
const isEmailSignupActive = authDisplay === AuthDisplay.Registration;
81+
const isEmailSignupActive =
82+
authDisplay === AuthDisplay.Registration ||
83+
authDisplay === AuthDisplay.EmailVerification;
8284
const isSocialSignupActive =
8385
isAuthReady &&
8486
isLoggedIn &&

packages/webapp/__tests__/TagPage.tsx

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import type { FeedData } from '@dailydotdev/shared/src/graphql/posts';
22
import { TAG_FEED_QUERY } from '@dailydotdev/shared/src/graphql/feed';
3+
import { PostType } from '@dailydotdev/shared/src/graphql/posts';
34
import nock from 'nock';
45
import AuthContext from '@dailydotdev/shared/src/contexts/AuthContext';
56
import React from 'react';
@@ -69,6 +70,14 @@ afterEach(() => {
6970
jest.clearAllMocks();
7071
});
7172

73+
const tagFeedSupportedTypes = [
74+
PostType.Article,
75+
PostType.VideoYouTube,
76+
PostType.Collection,
77+
PostType.Share,
78+
PostType.Freeform,
79+
];
80+
7281
const createFeedMock = (
7382
page = defaultFeedPage,
7483
query: string = TAG_FEED_QUERY,
@@ -78,6 +87,7 @@ const createFeedMock = (
7887
loggedIn: true,
7988
tag: 'react',
8089
ranking: 'TIME',
90+
supportedTypes: tagFeedSupportedTypes,
8191
},
8292
): MockedGraphQLResponse<FeedData> => ({
8393
request: {
@@ -264,6 +274,7 @@ it('should show follow and block buttons when logged-out', async () => {
264274
loggedIn: false,
265275
tag: 'react',
266276
ranking: 'TIME',
277+
supportedTypes: tagFeedSupportedTypes,
267278
}),
268279
],
269280
null,
@@ -284,6 +295,7 @@ it('should show login popup when logged-out on follow click', async () => {
284295
loggedIn: false,
285296
tag: 'react',
286297
ranking: 'TIME',
298+
supportedTypes: tagFeedSupportedTypes,
287299
}),
288300
],
289301
null,
@@ -313,6 +325,7 @@ it('should show login popup when logged-out on block click', async () => {
313325
loggedIn: false,
314326
tag: 'react',
315327
ranking: 'TIME',
328+
supportedTypes: tagFeedSupportedTypes,
316329
}),
317330
],
318331
null,

packages/webapp/pages/hackathon/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const HACKATHON_DESCRIPTION =
2525
'72 hours, the daily.dev Public API, and three open tracks. Build something for developers, from developers.';
2626

2727
// TODO move to cloudinary
28-
const HACKATHON_OG_IMAGE = fromCDN('/assets/hackathon-og.png');
28+
const HACKATHON_OG_IMAGE = fromCDN('/assets/hackathon-og.png?v=2');
2929

3030
const seoTitles = getPageSeoTitles(HACKATHON_TITLE);
3131
const seo: NextSeoProps = {

packages/webapp/pages/tags/[tag].tsx

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -296,6 +296,8 @@ const TagPage = ({
296296
PostType.Article,
297297
PostType.VideoYouTube,
298298
PostType.Collection,
299+
PostType.Share,
300+
PostType.Freeform,
299301
],
300302
period: 365,
301303
}),
@@ -309,6 +311,8 @@ const TagPage = ({
309311
PostType.Article,
310312
PostType.VideoYouTube,
311313
PostType.Collection,
314+
PostType.Share,
315+
PostType.Freeform,
312316
],
313317
}),
314318
[tag],
@@ -317,11 +321,31 @@ const TagPage = ({
317321
() => ({
318322
tag,
319323
period: 365,
324+
supportedTypes: [
325+
PostType.Article,
326+
PostType.VideoYouTube,
327+
PostType.Collection,
328+
PostType.Share,
329+
PostType.Freeform,
330+
],
320331
}),
321332
[tag],
322333
);
323334
// Must be memoized to prevent refreshing the feed
324-
const queryVariables = useMemo(() => ({ tag, ranking: 'TIME' }), [tag]);
335+
const queryVariables = useMemo(
336+
() => ({
337+
tag,
338+
ranking: 'TIME',
339+
supportedTypes: [
340+
PostType.Article,
341+
PostType.VideoYouTube,
342+
PostType.Collection,
343+
PostType.Share,
344+
PostType.Freeform,
345+
],
346+
}),
347+
[tag],
348+
);
325349
const { feedSettings } = useFeedSettings();
326350
const { FeedPageLayoutComponent } = useFeedLayout();
327351
const { onFollowTags, onUnfollowTags, onBlockTags, onUnblockTags } =
-86.3 KB
Loading

0 commit comments

Comments
 (0)