Skip to content

Commit 842fdd0

Browse files
fix(onboarding): inline prod image URL to avoid potential lazy module load race
Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent a5b65af commit 842fdd0

1 file changed

Lines changed: 8 additions & 12 deletions

File tree

packages/shared/src/features/onboarding/components/OnboardingSignupHero.tsx

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -18,12 +18,6 @@ import {
1818
ThemeMode,
1919
useSettingsContext,
2020
} from '../../../contexts/SettingsContext';
21-
import {
22-
cloudinaryAuthBannerBackground,
23-
cloudinaryAuthBannerBackground1440w,
24-
cloudinaryAuthBannerBackground1920w,
25-
} from '../../../lib/image';
26-
2721
const HERO_STYLES = `
2822
.onb-bg {
2923
background:
@@ -304,11 +298,13 @@ const DeskBackground = (): ReactElement => (
304298
// Image mode — production signup image (toggle overrides each variant)
305299
// =============================================================
306300

307-
const PROD_IMAGE_SRCSET = [
308-
`${cloudinaryAuthBannerBackground1440w} 1440w`,
309-
`${cloudinaryAuthBannerBackground1920w} 1920w`,
310-
`${cloudinaryAuthBannerBackground} 2880w`,
311-
].join(', ');
301+
const PROD_IMAGE_DEFAULT_SRC =
302+
'https://media.daily.dev/image/upload/s--lf8LUJjq--/f_auto/v1732012913/login-popover-dailydev_mxb7lw';
303+
const PROD_IMAGE_1440 =
304+
'https://media.daily.dev/image/upload/s--lf8LUJjq--/c_auto,g_center,w_1440/f_auto/v1732012913/login-popover-dailydev_mxb7lw';
305+
const PROD_IMAGE_1920 =
306+
'https://media.daily.dev/image/upload/s--lf8LUJjq--/c_auto,g_center,w_1920/f_auto/v1732012913/login-popover-dailydev_mxb7lw';
307+
const PROD_IMAGE_SRCSET = `${PROD_IMAGE_1440} 1440w, ${PROD_IMAGE_1920} 1920w, ${PROD_IMAGE_DEFAULT_SRC} 2880w`;
312308

313309
const ProdSignupBackground = ({
314310
splitMode = false,
@@ -326,7 +322,7 @@ const ProdSignupBackground = ({
326322
)}
327323
>
328324
<img
329-
src={cloudinaryAuthBannerBackground}
325+
src={PROD_IMAGE_DEFAULT_SRC}
330326
srcSet={PROD_IMAGE_SRCSET}
331327
sizes="100vw"
332328
alt=""

0 commit comments

Comments
 (0)