fix: new round of ts-strict fixes (#5869)

Author: rebelchris

packages/shared/src/components/tooltips/Portal.tsx

@@ -6,13 +6,13 @@ import { getCompanionWrapper } from '../../lib/extension';
 
 interface PortalProps {
   children: ReactNode;
-  container: Element;
+  container: Element | null;
 }
 
 export const Portal = ({
   children,
   container,
-}: PortalProps): ReturnType<typeof createPortal> => {
+}: PortalProps): ReturnType<typeof createPortal> | null => {
   if (!container) {
     return null;
   }

packages/webapp/pages/bookmarks/[folderId].tsx

@@ -17,7 +17,7 @@ const seo: NextSeoProps = {
   ...defaultSeo,
 };
 
-const BookmarksPage = (): ReactElement => {
+const BookmarksPage = (): ReactElement | null => {
   const router = useRouter();
   const { isAuthReady } = useAuthContext();
   const { isPlus } = usePlusSubscription();

packages/webapp/pages/feeds/[slugOrId]/edit.tsx

@@ -22,7 +22,7 @@ const seo: NextSeoProps = {
   ...defaultSeo,
 };
 
-const EditFeedPage = (): ReactElement => {
+const EditFeedPage = (): ReactElement | null => {
   const router = useRouter();
   const { FeedPageLayoutComponent } = useFeedLayout();
   const feedSlugOrId = router.query.slugOrId as string;

packages/webapp/pages/history.tsx

@@ -9,7 +9,7 @@ import ProtectedPage from '../components/ProtectedPage';
 import { getLayout } from '../components/layouts/MainLayout';
 import { getLayout as getFooterNavBarLayout } from '../components/layouts/FooterNavBarLayout';
 
-const History = (): ReactElement => {
+const History = (): ReactElement | null => {
   const isLaptop = useViewSize(ViewSize.Laptop);
   const router = useRouter();
 

packages/webapp/pages/jobs/index.tsx

@@ -26,7 +26,7 @@ const activeStatuses = [
   OpportunityMatchStatus.CandidateAccepted,
 ];
 
-const JobsPage = (): ReactElement => {
+const JobsPage = (): ReactElement | null => {
   const { checkHasCompleted, isActionsFetched, completeAction } = useActions();
   const { sidebarRendered } = useSidebarRendered();
   const hasUploadedCV = checkHasCompleted(ActionType.UploadedCV);

packages/webapp/pages/plus/index.tsx

@@ -54,7 +54,7 @@ export type PlusPageProps = Pick<GiftUserContextData, 'giftToUser'> &
 const PlusPage = ({
   giftToUser,
   shouldShowPlusHeader,
-}: PlusPageProps): ReactElement => {
+}: PlusPageProps): ReactElement | null => {
   const { logEvent } = useLogContext();
   const { isReady } = useRouter();
   const isLaptop = useViewSize(ViewSize.Laptop);

packages/webapp/pages/recruiter/review/[id].tsx

@@ -78,7 +78,7 @@ const ContentSection = ({
   );
 };
 
-const ReviewDetailPage = (): ReactElement => {
+const ReviewDetailPage = (): ReactElement | null => {
   const router = useRouter();
   const { id } = router.query;
   const { user, isAuthReady } = useAuthContext();

packages/webapp/pages/recruiter/review/index.tsx

@@ -75,7 +75,7 @@ const OpportunityCard = ({
   );
 };
 
-const ReviewListPage = (): ReactElement => {
+const ReviewListPage = (): ReactElement | null => {
   const router = useRouter();
   const { user, isAuthReady } = useAuthContext();