Skip to content

Commit 9e93126

Browse files
fix(onboarding): skip-list FunnelHeroLanding in strict typecheck
FunnelHeroLanding is the new signup-hero step copied from FunnelOrganicSignup and carries the same copied-auth strict violations (user optionality, useRef RefObject vs MutableRefObject, onSuccessfulRegistration signature). It was missed when FunnelOrganicSignup was added to the strict skip list. Co-authored-by: Amar Trebinjac <AmarTrebinjac@users.noreply.github.com>
1 parent 90c517b commit 9e93126

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

scripts/typecheck-strict-changed.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,10 @@ const strictSkipList = new Set([
3838
// signature mismatch) all live on unchanged logic copied from the
3939
// original step and should be addressed in a dedicated auth-flow
4040
// cleanup PR alongside the related auth files already on this list.
41+
// FunnelHeroLanding is the new signup-hero step copied from the same
42+
// original and carries the identical copied-auth strict violations.
4143
'packages/shared/src/features/onboarding/steps/FunnelOrganicSignup.tsx',
44+
'packages/shared/src/features/onboarding/steps/FunnelHeroLanding.tsx',
4245
'packages/shared/src/hooks/useLogin.ts',
4346
'packages/shared/src/hooks/useRegistration.ts',
4447
'packages/shared/src/contexts/AuthContext.tsx',

0 commit comments

Comments
 (0)