Skip to content

Commit b0d66ee

Browse files
committed
fix: explore page horizontal alignmenet on larger viewports
1 parent 1a93218 commit b0d66ee

2 files changed

Lines changed: 18 additions & 12 deletions

File tree

packages/shared/src/components/Feed.tsx

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -106,6 +106,7 @@ export interface FeedProps<T>
106106
isHorizontal?: boolean;
107107
feedContainerRef?: React.Ref<HTMLDivElement>;
108108
disableListFrame?: boolean;
109+
topContent?: ReactNode;
109110
}
110111

111112
interface RankVariables {
@@ -209,6 +210,7 @@ export default function Feed<T>({
209210
isHorizontal = false,
210211
feedContainerRef,
211212
disableListFrame = false,
213+
topContent: topContentProp,
212214
}: FeedProps<T>): ReactElement {
213215
const origin = Origin.Feed;
214216
const { logEvent } = useLogContext();
@@ -669,15 +671,17 @@ export default function Feed<T>({
669671
const containerProps = isSearchPageLaptop
670672
? {}
671673
: {
672-
topContent: shouldShowTopHero ? (
673-
<TopHero
674-
className="pt-2"
675-
title={readingReminderTitle}
676-
subtitle={readingReminderSubtitle}
677-
onCtaClick={() => onEnableHero(NotificationCtaPlacement.TopHero)}
678-
onClose={() => onDismissHero(NotificationCtaPlacement.TopHero)}
679-
/>
680-
) : undefined,
674+
topContent:
675+
topContentProp ??
676+
(shouldShowTopHero ? (
677+
<TopHero
678+
className="pt-2"
679+
title={readingReminderTitle}
680+
subtitle={readingReminderSubtitle}
681+
onCtaClick={() => onEnableHero(NotificationCtaPlacement.TopHero)}
682+
onClose={() => onDismissHero(NotificationCtaPlacement.TopHero)}
683+
/>
684+
) : undefined),
681685
header,
682686
inlineHeader,
683687
className,

packages/shared/src/components/MainFeedLayout.tsx

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -714,9 +714,6 @@ export default function MainFeedLayout({
714714
<FeedPageLayoutComponent
715715
className={classNames('relative', disableTopPadding && '!pt-0')}
716716
>
717-
{!!chipsNode && router.pathname === '/explore/[tag]' && (
718-
<div className="mb-8 w-full">{chipsNode}</div>
719-
)}
720717
{isAnyExplore && <FeedExploreComponent />}
721718
{isSearchOn && !isSearchPageLaptop && search}
722719
{isSearchOn && isFinder && !isSearchPageLaptop && (
@@ -756,6 +753,11 @@ export default function MainFeedLayout({
756753
<Feed
757754
{...feedProps}
758755
shortcuts={shortcuts}
756+
topContent={
757+
isExploreTag && chipsNode ? (
758+
<div className="mb-8 w-full">{chipsNode}</div>
759+
) : undefined
760+
}
759761
className={classNames(
760762
shouldUseListFeedLayout && !isFinder && 'laptop:px-6',
761763
)}

0 commit comments

Comments
 (0)