fix: new round of ts-strict fixes (#5871)

Author: rebelchris

packages/shared/src/hooks/bookmark/useBookmarkFolder.ts

@@ -18,7 +18,7 @@ interface UseBookmarkFolder {
   query: {
     isPending: boolean;
     isReady: boolean;
-    folder: BookmarkFolder;
+    folder?: BookmarkFolder;
   };
   update: {
     isPending: boolean;
@@ -62,7 +62,7 @@ export const useBookmarkFolder = ({
 
       logEvent({
         event_name: LogEvent.RenameBookmarkFolder,
-        target_id: folder.id,
+        target_id: folder!.id,
       });
     },
     onError: () => {

packages/shared/src/hooks/integrations/slack/useSlack.ts

@@ -37,11 +37,11 @@ export const useSlack = (): UseSlack => {
       const redirectUrl = new URL(`${apiUrl}/integrations/slack/auth/callback`);
       url.searchParams.append('redirect_uri', redirectUrl.toString());
 
-      url.searchParams.append('state', user.id);
+      url.searchParams.append('state', user!.id);
       url.searchParams.append('scope', scopes.join(','));
       url.searchParams.append(
         'client_id',
-        process.env.NEXT_PUBLIC_SLACK_CLIENT_ID,
+        process.env.NEXT_PUBLIC_SLACK_CLIENT_ID!,
       );
 
       setCookie('slackRedirectPath', redirectPath, {
@@ -54,7 +54,7 @@ export const useSlack = (): UseSlack => {
 
       window.location.href = url.toString();
     },
-    [user?.id],
+    [user],
   );
 
   const connectSource = useCallback<UseSlack['connectSource']>(

packages/shared/src/hooks/post/usePostCodeSnippets.ts

@@ -42,7 +42,7 @@ export const usePostCodeSnippetsQuery = ({
   const enabled = !!postId;
 
   const queryResult = useInfiniteQuery({
-    queryKey: generateQueryKey(RequestKey.PostCodeSnippets, null, {
+    queryKey: generateQueryKey(RequestKey.PostCodeSnippets, undefined, {
       id: postId,
     }),
     queryFn: async ({ pageParam }) => {
@@ -65,10 +65,6 @@ export const usePostCodeSnippetsQuery = ({
         : enabled,
     getNextPageParam: (lastPage) => getNextPageParam(lastPage?.pageInfo),
     select: useCallback((data: InfiniteData<UsePostCodeSnippetsData>) => {
-      if (!data) {
-        return undefined;
-      }
-
       return {
         ...data,
         // filter out last page with no edges returned by api paginator

packages/shared/src/hooks/post/usePostImage.ts

@@ -2,7 +2,7 @@ import { useMemo } from 'react';
 import { PostType } from '../../graphql/posts';
 import type { Post } from '../../graphql/posts';
 
-export const usePostImage = (post: Post): string =>
+export const usePostImage = (post: Post): string | undefined =>
   useMemo(() => {
     if (post?.type === PostType.SocialTwitter && post?.subType === 'thread') {
       return undefined;
@@ -15,10 +15,10 @@ export const usePostImage = (post: Post): string =>
     }
 
     const parser = new DOMParser();
-    const doc = parser.parseFromString(post?.contentHtml, 'text/html');
+    const doc = parser.parseFromString(post?.contentHtml ?? '', 'text/html');
     const imgTag = doc.querySelector('img');
     if (imgTag) {
-      return imgTag.getAttribute('src');
+      return imgTag.getAttribute('src') ?? undefined;
     }
 
     return undefined;

packages/shared/src/hooks/post/useRelatedPosts.ts

@@ -29,7 +29,7 @@ export type UseRelatedPostsProps = {
 type RelatedPostsQueryData = Connection<RelatedPost>;
 
 export type UseRelatedPosts = {
-  relatedPosts: InfiniteData<RelatedPostsQueryData>;
+  relatedPosts?: InfiniteData<RelatedPostsQueryData>;
   isLoading: boolean;
   hasNextPage: boolean;
   fetchNextPage: UseInfiniteQueryResult['fetchNextPage'];
@@ -51,7 +51,7 @@ export const useRelatedPosts = ({
     fetchNextPage,
     isFetchingNextPage,
   } = useInfiniteQuery({
-    queryKey: generateQueryKey(RequestKey.RelatedPosts, null, {
+    queryKey: generateQueryKey(RequestKey.RelatedPosts, undefined, {
       id: postId,
       type: relationType,
     }),

packages/shared/src/hooks/post/useViewPost.ts

@@ -20,11 +20,13 @@ export const useViewPost = (): UseMutateAsyncFunction<
     onSuccess: async () => {
       const streak = client.getQueryData<UserStreak>(streakKey);
       const isNewStreak = !streak?.lastViewAt;
-      const isFirstViewToday = !isSameDayInTimezone(
-        new Date(streak?.lastViewAt),
-        new Date(),
-        user.timezone,
-      );
+      const isFirstViewToday =
+        !isNewStreak &&
+        !isSameDayInTimezone(
+          new Date(streak!.lastViewAt!),
+          new Date(),
+          user!.timezone,
+        );
 
       if (isNewStreak || isFirstViewToday) {
         await client.refetchQueries({ queryKey: streakKey });

packages/shared/src/hooks/profile/useDevCard.ts

@@ -31,7 +31,7 @@ export interface DevCardQueryData {
 }
 
 export interface UseDevCard {
-  devcard: DevCardData;
+  devcard: Partial<DevCardData> & { streak: { max: number } };
   isLoading: boolean;
   coverImage: string;
 }
@@ -53,13 +53,13 @@ export const useDevCard = (userId: string): UseDevCard => {
 
   const { isProfileCover, user } = devCard ?? {};
   const coverImage =
-    (isProfileCover ? user.cover : undefined) ??
+    (isProfileCover ? user!.cover : undefined) ??
     cloudinaryDevcardDefaultCoverImage;
 
   return {
     devcard: {
       ...devCard,
-      streak: { ...userStreakProfile },
+      streak: { max: userStreakProfile?.max ?? 0 },
     },
     isLoading,
     coverImage,

packages/shared/src/hooks/profile/useProfile.ts

@@ -16,15 +16,15 @@ export function useProfile(initialUser?: PublicProfile): {
   });
   const { data: user } = useQuery({
     queryKey: userQueryKey,
-    queryFn: () => getProfile(initialUser?.id),
+    queryFn: () => getProfile(initialUser!.id),
     ...disabledRefetch,
     staleTime: StaleTime.OneHour,
     initialData: initialUser,
     enabled: !!initialUser?.id,
   });
 
   return {
-    user,
+    user: user!,
     userQueryKey,
     isUserSame: !!(loggedUser && loggedUser?.id === initialUser?.id),
   };

packages/shared/src/hooks/source/useSourcePostModerationById.ts

@@ -5,7 +5,7 @@ import { useAuthContext } from '../../contexts/AuthContext';
 import { getSourcePostModeration } from '../../graphql/posts';
 
 interface UseSourcePostModerationById {
-  moderated: SourcePostModeration;
+  moderated?: SourcePostModeration;
   isLoading: boolean;
 }
 
@@ -21,7 +21,7 @@ export const useSourcePostModerationById = ({
   const { user } = useAuthContext();
   const { data, isLoading } = useQuery({
     queryKey: generateQueryKey(RequestKey.SourcePostModeration, user, id),
-    queryFn: () => getSourcePostModeration({ id }),
+    queryFn: () => getSourcePostModeration({ id: id! }),
     enabled: !!id && enabled,
   });
 

packages/shared/src/hooks/streaks/useReadingStreak.ts

@@ -20,7 +20,7 @@ type UpdateReadingStreakConfig = {
 };
 
 interface UserReadingStreak {
-  streak: UserStreak;
+  streak?: UserStreak;
   isLoading: boolean;
   isUpdatingConfig: boolean;
   checkReadingStreak: () => void;
@@ -67,7 +67,7 @@ export const useReadingStreak = (): UserReadingStreak => {
       isSameDayInTimezone(
         new Date(streak.lastViewAt),
         new Date(),
-        user.timezone,
+        user!.timezone,
       );
 
     if (!hasReadToday) {