fix: unwrap FeedApiItem before using as Post in cache updates (#5839)

Author: capJavert

packages/shared/src/hooks/translation/useTranslation.ts

@@ -10,6 +10,7 @@ import type {
   TranslateablePostField,
 } from '../../graphql/posts';
 import { PostType } from '../../graphql/posts';
+import { getFeedApiItemPost } from '../../graphql/feed';
 import {
   updateCachedPagePost,
   findIndexOfPostInData,
@@ -173,11 +174,19 @@ export const useTranslation: UseTranslation = ({
         true,
       );
       if (index > -1) {
+        const post = getFeedApiItemPost(
+          feedData.pages[pageIndex].page.edges[index].node,
+        );
+
+        if (!post) {
+          return;
+        }
+
         updatePost(
           pageIndex,
           index,
           updateTranslation({
-            post: feedData.pages[pageIndex].page.edges[index].node,
+            post,
             translation: translatedPost,
           }),
         );

packages/shared/src/hooks/usePoll.tsx

@@ -2,6 +2,7 @@ import React from 'react';
 import type { InfiniteData } from '@tanstack/react-query';
 import { useMutation, useQueryClient } from '@tanstack/react-query';
 import type { Ad, FeedData, Post } from '../graphql/posts';
+import { getFeedApiItemPost } from '../graphql/feed';
 import { votePoll } from '../graphql/posts';
 import {
   findIndexOfPostInData,
@@ -67,12 +68,16 @@ const usePoll = ({ post }: { post: Post }) => {
         );
 
         if (pageIndex > -1 && index > -1) {
-          const currentPost = feedData.pages[pageIndex].page.edges[index].node;
-          const updatedPost = {
-            ...currentPost,
-            ...postUpdate,
-          };
-          updateFeed(pageIndex, index, updatedPost);
+          const currentPost = getFeedApiItemPost(
+            feedData.pages[pageIndex].page.edges[index].node,
+          );
+
+          if (currentPost) {
+            updateFeed(pageIndex, index, {
+              ...currentPost,
+              ...postUpdate,
+            });
+          }
         }
       }