Skip to content

Commit f14d5e8

Browse files
fix(onboarding): swap prod image to actual signup wall artwork
The 'Prod image' mode was pointing at the auth-banner popover background (login-popover-dailydev, a 2880x406 purple gradient strip). Stretched to fullscreen with object-cover it produced a near-invisible dark wash — which is why the image appeared missing. Switch to the real production signup-wall image (dailydev_where_developers_suffer_together) with a mobile variant via <picture>. Also hide the cabbage/water orbs in prod mode so mix-blend-mode doesn't tint the artwork, and lighten the prod scrim so the desk illustration stays visible behind the form. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 842fdd0 commit f14d5e8

1 file changed

Lines changed: 48 additions & 46 deletions

File tree

packages/shared/src/features/onboarding/components/OnboardingSignupHero.tsx

Lines changed: 48 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -92,10 +92,10 @@ const HERO_STYLES = `
9292
.onb-prod-scrim {
9393
background: linear-gradient(
9494
to top,
95-
rgba(8, 8, 12, 0.92) 0%,
96-
rgba(8, 8, 12, 0.78) 24%,
97-
rgba(8, 8, 12, 0.45) 52%,
98-
rgba(8, 8, 12, 0.15) 78%,
95+
rgba(8, 8, 12, 0.78) 0%,
96+
rgba(8, 8, 12, 0.55) 28%,
97+
rgba(8, 8, 12, 0.25) 58%,
98+
rgba(8, 8, 12, 0.05) 82%,
9999
transparent 100%
100100
);
101101
}
@@ -298,13 +298,12 @@ const DeskBackground = (): ReactElement => (
298298
// Image mode — production signup image (toggle overrides each variant)
299299
// =============================================================
300300

301-
const PROD_IMAGE_DEFAULT_SRC =
302-
'https://media.daily.dev/image/upload/s--lf8LUJjq--/f_auto/v1732012913/login-popover-dailydev_mxb7lw';
303-
const PROD_IMAGE_1440 =
304-
'https://media.daily.dev/image/upload/s--lf8LUJjq--/c_auto,g_center,w_1440/f_auto/v1732012913/login-popover-dailydev_mxb7lw';
305-
const PROD_IMAGE_1920 =
306-
'https://media.daily.dev/image/upload/s--lf8LUJjq--/c_auto,g_center,w_1920/f_auto/v1732012913/login-popover-dailydev_mxb7lw';
307-
const PROD_IMAGE_SRCSET = `${PROD_IMAGE_1440} 1440w, ${PROD_IMAGE_1920} 1920w, ${PROD_IMAGE_DEFAULT_SRC} 2880w`;
301+
// The actual desktop + mobile artwork used on the live signup wall.
302+
// Source: cloudinaryOnboardingFullBackgroundDesktop / Mobile in shared/lib/image.
303+
const PROD_IMAGE_DESKTOP =
304+
'https://media.daily.dev/image/upload/s--r2ffZPB4--/f_auto/v1716969841/dailydev_where_developers_suffer_together_sfvfog';
305+
const PROD_IMAGE_MOBILE =
306+
'https://media.daily.dev/image/upload/s--EwsBTBt6--/f_auto/v1716969841/dailydev_where_developers_suffer_together_mobile_shkn1w';
308307

309308
const ProdSignupBackground = ({
310309
splitMode = false,
@@ -321,15 +320,16 @@ const ProdSignupBackground = ({
321320
visible ? 'opacity-100' : 'opacity-0',
322321
)}
323322
>
324-
<img
325-
src={PROD_IMAGE_DEFAULT_SRC}
326-
srcSet={PROD_IMAGE_SRCSET}
327-
sizes="100vw"
328-
alt=""
329-
className="absolute inset-0 h-full w-full object-cover object-center"
330-
decoding="async"
331-
fetchPriority="high"
332-
/>
323+
<picture>
324+
<source media="(max-width: 768px)" srcSet={PROD_IMAGE_MOBILE} />
325+
<img
326+
src={PROD_IMAGE_DESKTOP}
327+
alt=""
328+
className="absolute inset-0 h-full w-full object-cover object-center"
329+
decoding="async"
330+
fetchPriority="high"
331+
/>
332+
</picture>
333333
</div>
334334
);
335335

@@ -655,36 +655,38 @@ export const OnboardingSignupHero = ({
655655
/>
656656
{renderVariantBackground('split', imageMode)}
657657
{!isProdImageMode && (
658-
<div
659-
aria-hidden
660-
className="onb-split-left-fade pointer-events-none absolute inset-0 -z-1"
661-
/>
658+
<>
659+
<div
660+
aria-hidden
661+
className="onb-split-left-fade pointer-events-none absolute inset-0 -z-1"
662+
/>
663+
<span
664+
className="onb-orb bg-accent-cabbage-default"
665+
style={{
666+
width: '38rem',
667+
height: '38rem',
668+
top: '-10rem',
669+
left: '-8rem',
670+
}}
671+
/>
672+
<span
673+
aria-hidden
674+
className="onb-orb onb-orb--delay bg-accent-water-default"
675+
style={{
676+
width: '32rem',
677+
height: '32rem',
678+
bottom: '-8rem',
679+
left: '5%',
680+
top: 'auto',
681+
right: 'auto',
682+
}}
683+
/>
684+
</>
662685
)}
663-
<span
664-
className="onb-orb bg-accent-cabbage-default"
665-
style={{
666-
width: '38rem',
667-
height: '38rem',
668-
top: '-10rem',
669-
left: '-8rem',
670-
}}
671-
/>
672-
<span
673-
aria-hidden
674-
className="onb-orb onb-orb--delay bg-accent-water-default"
675-
style={{
676-
width: '32rem',
677-
height: '32rem',
678-
bottom: '-8rem',
679-
left: '5%',
680-
top: 'auto',
681-
right: 'auto',
682-
}}
683-
/>
684686
</div>
685687
)}
686688

687-
{!isSplitLayout && (
689+
{!isSplitLayout && !isProdImageMode && (
688690
<div
689691
aria-hidden
690692
className="pointer-events-none absolute inset-0 -z-1 select-none"

0 commit comments

Comments
 (0)