Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Buttonchildren inside a stable.btn-labelwrapper across loading state changes<span>Root Cause
Chrome's native translation feature mutates button text nodes outside React's control. Our shared
Buttoncomponent swapped a direct text child for a new wrapper element whenloadingbecametrue, so React later tried to remove a child node that Chrome Translate had already rewritten. That produced theremoveChild/NotFoundErrorcrash.Impact
This fixes the translated onboarding social signup crash and reduces the same DOM-mutation risk anywhere else the shared loading button is used.
Validation
testEnvironmentOptionsinitializationPreview domain
https://codex-fix-translate-button-loadi.preview.app.daily.dev