feat(webapp): streamline onboarding v2 landing layout and hero#5897
Open
tsahimatsliah wants to merge 5 commits intomainfrom
Open
feat(webapp): streamline onboarding v2 landing layout and hero#5897tsahimatsliah wants to merge 5 commits intomainfrom
tsahimatsliah wants to merge 5 commits intomainfrom
Conversation
Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
capJavert
approved these changes
Apr 22, 2026
Contributor
capJavert
left a comment
There was a problem hiding this comment.
Added some style/events adjustments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refreshes the Onboarding V2 landing experience (hero step) to reduce friction: a focused full-viewport layout, clearer headline typography, and footer always visible without scrolling the page.
Feature flag (no new flag)
featureManagement: still gated by existingfeatureOnboardingV2→ keyonboarding_v2(defaultfalse).packages/webapp/pages/onboarding.tsxrenders<OnboardingV2 />when this flag is on; no additional experiment flag was added.UX / layout
OnboardingChooserGrid) lives in the hero; removed the live feed preview on the hero step, dummy left sidebar, animated rising tags, long subtitle, and duplicate hero CTAs (the two paths are only in the chooser cards).typo-title1on small screens andtablet:typo-large-titleplus slightly relaxed line height on tablet+.min-h-dvhflex column whenstep === 'hero'; footer usesmt-auto;document.bodyoverflow is hidden on the hero step so the page does not scroll behind the layout.FooterLinksstays at the bottom of the viewport on the hero step (with safe-area padding where relevant).Flow unchanged
Signup/auth modals, import overlay, tags fallback, extension promo, completion screen, and other steps after leaving the hero are unchanged.
Testing
node ./scripts/typecheck-strict-changed.jspnpm exec eslint components/onboarding/OnboardingV2.tsx(webapp)How to QA: Enable
onboarding_v2for your user/session, open/onboarding, confirm hero-only layout, no page scroll on hero, footer visible, and both chooser paths still work.Made with Cursor
Preview domain
https://feat-onboarding-v2-landing-refre.preview.app.daily.dev