fix(shared): align award modal button content on mobile#5901
Closed
AmarTrebinjac wants to merge 2 commits intomainfrom
Closed
fix(shared): align award modal button content on mobile#5901AmarTrebinjac wants to merge 2 commits intomainfrom
AmarTrebinjac wants to merge 2 commits intomainfrom
Conversation
Make btn-label span a flex container so mixed children (text + icons + price) align properly on mobile. Remove the redundant inline-flex workaround span from the Insufficient Cores button. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@claude since this is a 1 off lets not make the changes in the button component. |
Contributor
|
Claude finished @AmarTrebinjac's task in 1m 58s —— View job • Tasks
SummaryApplied the alignment fix as a one-off directly in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flex items-center gap-1to thebtn-labelspan inButton.tsxso mixed children (text + icons + price) align properly on mobile<span className="inline-flex gap-1">workaround from the "Insufficient Cores" button inGiveAwardModal.tsxKey decisions
Buttoncomponent level rather than adding per-button overrides — the outer element is alreadyinline-flex items-center, so making the inner label span flex is consistent and prevents this issue from recurringgap-1has no effect on buttons with a single text child, so existing buttons are unaffectedTest plan
Closes ENG-1292
Created by Huginn 🐦⬛
Preview domain
https://eng-1292-fix-award-button.preview.app.daily.dev