feat: add conditional rendering to marketing CTA based on target platform#5021
Merged
omBratteng merged 3 commits intomainfrom Oct 30, 2025
Merged
feat: add conditional rendering to marketing CTA based on target platform#5021omBratteng merged 3 commits intomainfrom
omBratteng merged 3 commits intomainfrom
Conversation
omBratteng
requested review from
AmarTrebinjac,
capJavert,
ilasw,
nensidosari,
rebelchris and
sshanzel
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sshanzel
approved these changes
Oct 29, 2025
rebelchris
approved these changes
Oct 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add conditional rendering to marketing CTAs, so that we can condtionally choose on what platform to render it on, so we can re-use existing variants, without creating platform specific just to render on extension or on iOS.
Example usecase is for the linkedin button, where we want to only render the popover in extension, but not on iOS or webapp.
API PR
dailydotdev/daily-api#3240
Preview domain
https://feat-conditional-marketing-cta.preview.app.daily.dev