Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
@rebelchris have you verified responsiveness of the modal? (e.g mobile) |
idoshamun
approved these changes
Nov 10, 2025
idoshamun
requested changes
Nov 10, 2025
Member
idoshamun
left a comment
idoshamun
left a comment
There was a problem hiding this comment.
Let's just make sure we include the nudge analytics. I added target_id
Contributor
Author
Will add the tracking :) |
Member
|
Seems like on the image you shared we need to have less opacity. It gets blended with the background |
Contributor
Author
|
@idoshamun mobile is now drawer, and added the tracking + targetID |
idoshamun
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
New job match modal
It's non guidelined so quite bit custom stuff.
It shows if you have alert and not dismissed it.
The dismiss state resets on new one: dailydotdev/daily-api#3267
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://feat-job-opportunity-modal.preview.app.daily.dev