Skip to content

fix: add image prop to social signup#5064

Merged
AmarTrebinjac merged 1 commit intoMI-1027-profilefrom
ENG-36
Nov 13, 2025
Merged

fix: add image prop to social signup#5064
AmarTrebinjac merged 1 commit intoMI-1027-profilefrom
ENG-36

Conversation

@AmarTrebinjac
Copy link
Copy Markdown
Contributor

@AmarTrebinjac AmarTrebinjac commented Nov 12, 2025

Changes

Since we use the image prop to determine whether the user deleted their current image or not in the updated updateUserProfile endpoint, we needed to make this change so the social profile doesn't get delete right after account creation

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://eng-36.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 12, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
daily-webapp Ready Ready Preview Nov 12, 2025 11:13pm
1 Skipped Deployment
Project Deployment Preview Updated (UTC)
storybook Ignored Ignored Nov 12, 2025 11:13pm

@AmarTrebinjac AmarTrebinjac marked this pull request as ready for review November 12, 2025 23:12
@AmarTrebinjac AmarTrebinjac requested a review from a team as a code owner November 12, 2025 23:12
@AmarTrebinjac AmarTrebinjac requested review from capJavert, omBratteng and rebelchris and removed request for a team November 12, 2025 23:12
@AmarTrebinjac AmarTrebinjac merged commit 3e7cda0 into MI-1027-profile Nov 13, 2025
13 checks passed
@AmarTrebinjac AmarTrebinjac deleted the ENG-36 branch November 13, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants