feat: add a no-ai toggle to my feed

[nimrodkra]

Summary

• add a GrowthBook-gated No AI mode control for My Feed with the final header UI, tooltip copy, and Cloudinary artwork
• save the preference to account settings, expose it in Feed settings -> Content preferences, and support hiding the homepage toggle after applying it
• replace the first-run modal with a lighter toast CTA and polish the copy/styling based on review feedback

Test plan

• pnpm --filter @dailydotdev/shared lint
• node ./scripts/typecheck-strict-changed.js
• NODE_ENV=test pnpm --filter @dailydotdev/shared test -- --runTestsByPath src/components/layout/common.spec.tsx src/hooks/useNoAiFeed.spec.ts

Notes

• feature remains gated behind no_ai_feed
• saved preference is available from Feed settings -> Content preferences
• header toggle is desktop-only

Made with Cursor

Preview domain

https://feat-no-ai-feed-toggle.preview.app.daily.dev

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
daily-webapp	Ready	Preview	Apr 3, 2026 5:54pm

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
storybook	Ignored		Apr 3, 2026 5:54pm

[nimrodkra]

@claude please review this pr

[claude]

Claude finished @nimrodkra's task in 3m 5s —— View job

---

PR Review: feat/no-ai-feed-toggle

• Gather context
• Read changed files
• Analyze for bugs, issues, and best practices
• Post review feedback

---

Overall the implementation is clean and well-structured. A few issues worth addressing before merging:

Issues

1. FEED_QUERY_WITH_NO_AI is a redundant duplicate of FEED_QUERY

FEED_QUERY was already modified to accept $noAi: Boolean and pass noAi: $noAi. The newly added FEED_QUERY_WITH_NO_AI is structurally identical — the only difference is the GraphQL operation name (FeedWithNoAi vs Feed).

React Query caches by query key (which includes variables), not the GraphQL operation name. So having a different operation name provides zero caching benefit. The two queries are interchangeable, and FEED_QUERY_WITH_NO_AI can be deleted.

packages/shared/src/graphql/feed.ts lines 158–185 — the entire FEED_QUERY_WITH_NO_AI export can be removed. Both places in MainFeedLayout.tsx that use it should revert to FEED_QUERY. Fix this →

2. propsByFeed['my-feed'].queryIfLogged change is dead code

packages/shared/src/components/MainFeedLayout.tsx line 121:

'my-feed': {
  query: ANONYMOUS_FEED_QUERY,
  queryIfLogged: FEED_QUERY_WITH_NO_AI,  // ← never used
},

Inside the useMemo, dynamicPropsByFeed[SharedFeedPage.MyFeed] always sets queryIfLogged to myFeedLoggedInQuery, and dynamicFeedConfig?.queryIfLogged takes precedence (line 368):

dynamicFeedConfig?.queryIfLogged || feedConfig.queryIfLogged || null,

So the propsByFeed assignment is overridden 100% of the time. Reverting this line back to FEED_QUERY (or leaving it as-is once FEED_QUERY_WITH_NO_AI is removed) avoids confusion about what the static config actually does. Fix this →

3. No analytics event on toggle

There's no logEvent call in useNoAiFeed or in the SearchControlHeader when the No AI toggle is activated/deactivated. For a GrowthBook experiment, measuring toggle interactions is essential. Consider calling useLogContext and firing a LogEvent when toggleNoAi is called, similar to how ToggleClickbaitShield logs events.

Minor Issues

4. Unnecessary async wrapper in onClick

packages/shared/src/components/layout/common.tsx lines 203–205:

onClick={async () => {
  await noAiState.onToggle();
}}

Since you're not doing anything after the await, this can be simplified to:

onClick={noAiState.onToggle}

5. Mutable let for button variant

packages/shared/src/components/layout/common.tsx lines 162–166:

let noAiButtonVariant = isLaptop ? ButtonVariant.Float : ButtonVariant.Tertiary;
if (noAiState?.isEnabled) {
  noAiButtonVariant = ButtonVariant.Primary;
}

Could be a single expression:

const noAiButtonVariant = noAiState?.isEnabled
  ? ButtonVariant.Primary
  : isLaptop ? ButtonVariant.Float : ButtonVariant.Tertiary;

What Looks Good

• useNoAiFeed is clean: isLoaded logic correctly gates on both feature flag and IDB fetch
• shouldEvaluateNoAi correctly limits GrowthBook evaluation to My Feed only (not custom default feeds)
• usePersistentContext types confirmed — setStoredValue is mutateAsync, so toggleNoAi: () => Promise<void> is correctly typed
• The pressed prop on the Button for accessibility is the right pattern
• Blocking render with if (shouldEvaluateNoAi && !isNoAiLoaded) return null is consistent with the component's existing loading guard pattern
• Feature flag featureNoAiFeed = new Feature('no_ai_feed', false) — safe default of false

[nimrodkra]

Addressed the review and tightened the UX on this branch:

Review items addressed:

• removed the redundant FEED_QUERY_WITH_NO_AI duplicate and reverted My Feed back to FEED_QUERY
• removed the dead propsByFeed['my-feed'].queryIfLogged override path
• added toggle analytics via LogEvent.ToggleNoAiFeed

UX updates:

• replaced the header button with a real switch
• moved the No AI control into its own right-aligned card so it stands apart from the existing left-side feed controls
• updated the copy to a clearer / more playful "No AI mode"
• added helper tooltip copy explaining the filter behavior and that it is intentionally aggressive
• incorporated the supplied anti-bot image into the control using existing shared primitives (LazyImage, Switch, Tooltip, Typography)

Verification:

• pnpm --filter @dailydotdev/shared lint
• node ./scripts/typecheck-strict-changed.js
• NODE_ENV=test pnpm --filter @dailydotdev/shared test -- --runTestsByPath src/components/layout/common.spec.tsx

[nimrodkra]

@claude run another code review after all the latest changes I've made here

[claude]

Claude finished @nimrodkra's task in 1m 51s —— View job

---

PR Review: feat/no-ai-feed-toggle (round 2)

• Gather context
• Read changed files
• Analyze for bugs, issues, and best practices
• Post review feedback

---

All issues from the first review have been addressed. The refactor from a button to a Switch card is clean, analytics are wired correctly, and the redundant query duplicate is gone. A few minor items worth a pass:

Issues

1. Dead Origin.CustomFeed branch in analytics

packages/shared/src/components/layout/common.tsx lines 186–191:

extra: JSON.stringify({
  origin:
    feedName === SharedFeedPage.Custom ? Origin.CustomFeed : Origin.Feed,
}),

noAiState is only passed from MainFeedLayout when shouldEvaluateNoAi is true, which requires feedName === SharedFeedPage.MyFeed && !isCustomDefaultFeed. The toggle never renders on Custom feeds, so Origin.CustomFeed is unreachable. The conditional can be replaced with just Origin.Feed. Fix this →

2. Unreachable guard in handleNoAiToggle

packages/shared/src/components/layout/common.tsx lines 178–181:

const handleNoAiToggle = async () => {
  if (!noAiState) {
    return;
  }

handleNoAiToggle is only used inside noAiState?.isAvailable && (...), so noAiState is always defined when this fires. The early-return guard is dead code. Fix this →

Minor Notes

3. Missing test for isAvailable: false

common.spec.tsx covers: toggle renders when isAvailable: true, logs correctly on click. There's no test asserting the control is absent when isAvailable: false. Low risk since noAiState?.isAvailable && is straightforward, but a one-liner assertion (expect(screen.queryByText('No AI mode')).not.toBeInTheDocument()) would add confidence.

4. shouldEvaluate default in useNoAiFeed

packages/shared/src/hooks/useNoAiFeed.ts line 20: shouldEvaluate = true. If anyone calls useNoAiFeed() bare (without the prop), it evaluates the GrowthBook flag and reads from IndexedDB unconditionally. The hook is only called from MainFeedLayout today, but a defensive default of false would match the CLAUDE.md principle of only evaluating flags when the component is in scope. Low priority.

What Looks Good

• isLoaded logic is solid: correctly short-circuits IDB wait when the feature flag is off
• shouldEvaluateNoAi = feedName === SharedFeedPage.MyFeed && !isCustomDefaultFeed properly excludes custom default feeds from the flag evaluation
• noAi: true is only spread into variables when actually active — no spurious noAi: false sent to the API
• Query key includes noAi via Object.values(variables) — TanStack Query will properly re-fetch on toggle
• Switch with checked + aria-label is the correct accessibility pattern
• Image committed to both webapp/public/assets/ and extension/public/assets/ for cross-platform coverage
• Test uses waitFor to assert async log call after toggle — correct pattern

[nimrodkra]

Addressed the latest follow-up here: removed the redundant My Feed query override, replaced the first-run modal with a lighter toast CTA, moved the saved No AI setting higher in Content preferences, and simplified the header control so it no longer depends on the local toggle image asset.

[capJavert]

Just image link again