Skip to content

fix(shared): guard malformed normalized feed items#5837

Open
idoshamun wants to merge 2 commits intomainfrom
eng-1221-cannot-read-properties-of-undefined-reading-id
Open

fix(shared): guard malformed normalized feed items#5837
idoshamun wants to merge 2 commits intomainfrom
eng-1221-cannot-read-properties-of-undefined-reading-id

Conversation

@idoshamun
Copy link
Copy Markdown
Member

@idoshamun idoshamun commented Apr 5, 2026

What changed

  • guard malformed normalized feed items before feed rendering consumes post.id
  • keep the fix narrow to the feed consumption path instead of rewriting normalized feed data
  • add a regression test covering malformed normalized post items on the shared feed path

Key decisions

  • preserve existing feedV2 normalization behavior and avoid broad cache-shape changes
  • return null for malformed normalized post items so the UI skips bad data instead of crashing

Closes ENG-1221


Created by Huginn 🐦‍⬛

Preview domain

https://eng-1221-cannot-read-properties.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Apr 5, 2026 7:29pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Apr 5, 2026 7:29pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant