fix: new round of ts-strict fixes

packages/shared/src/components/ExtensionOnboarding.tsx

@@ -12,9 +12,9 @@ const ExtensionOnboarding = (): ReactElement => {
   const { setCurrentPage } = useExtensionContext();
 
   useEffect(() => {
-    setCurrentPage('/hijacking');
+    setCurrentPage!('/hijacking');
     return () => {
-      setCurrentPage('/');
+      setCurrentPage!('/');
     };
   }, [setCurrentPage]);
 

packages/shared/src/components/cards/brief/BriefCard/BriefCardLoading.tsx

@@ -37,12 +37,12 @@ export const BriefCardLoading = ({
     >
       <LottieAnimation
         className="float-animation -mb-6 h-20 w-20"
-        src={animationSrc}
+        src={animationSrc ?? ''}
       />
       <div className="w-20">
         <ProgressBar
           shouldShowBg
-          percentage={progressPercentage}
+          percentage={progressPercentage ?? 0}
           className={{
             wrapper: 'rounded-12 bg-border-subtlest-tertiary',
             bar: 'h-1',

packages/shared/src/components/cards/collection/CollectionCardHeader.tsx

@@ -37,8 +37,8 @@ export const CollectionCardHeader = ({
             highlightBookmarkedPost && headerHiddenClassName,
           ),
         }}
-        sources={sources}
-        totalSources={totalSources}
+        sources={sources ?? []}
+        totalSources={totalSources ?? 0}
       >
         <div className="flex-1" />
         <PostOptionButton

packages/shared/src/components/cards/common/PollMetadata.tsx

@@ -21,7 +21,8 @@ const PollMetadata = ({
   isAuthor,
   numPollVotes,
 }: PollMetadataProps) => {
-  const shouldShowVotes = numPollVotes > MIN_VOTES_REQUIRED || isAuthor;
+  const votes = numPollVotes ?? 0;
+  const shouldShowVotes = votes > MIN_VOTES_REQUIRED || isAuthor;
   const pollHasEnded = endsAt && isAfter(new Date(), new Date(endsAt));
 
   return (
@@ -49,7 +50,7 @@ const PollMetadata = ({
       {shouldShowVotes && (
         <>
           <Typography tag={TypographyTag.Span} type={TypographyType.Footnote}>
-            {largeNumberFormat(numPollVotes)}{' '}
+            {largeNumberFormat(votes)}{' '}
             {pollHasEnded ? 'total votes' : 'votes'}
           </Typography>
           <Separator />

packages/shared/src/components/cards/common/RaisedLabel.tsx

@@ -56,7 +56,7 @@ export function RaisedLabel({
         )}
       >
         <ConditionalWrapper
-          condition={description?.length > 0}
+          condition={!!description}
           wrapper={(children) => (
             <Tooltip content={description}>{children}</Tooltip>
           )}
@@ -84,7 +84,7 @@ export function RaisedLabel({
       )}
     >
       <ConditionalWrapper
-        condition={description?.length > 0}
+        condition={!!description}
         wrapper={(children) => (
           <Tooltip content={description}>{children}</Tooltip>
         )}

packages/shared/src/components/cards/common/SourceButton.tsx

@@ -64,7 +64,7 @@ export default function SourceButton({
           className={className}
           picture={{ size, rounded: 'full' }}
           user={{
-            id: source.id,
+            id: source.id!,
             image: source.image,
             permalink: source.permalink,
             username: source.handle,
@@ -86,7 +86,7 @@ export default function SourceButton({
           className={className}
           picture={{ size, rounded: 'full' }}
           user={{
-            id: source.id,
+            id: source.id!,
             image: source.image,
             permalink: source.permalink,
             username: source.handle,

packages/shared/src/components/cards/common/list/PostCardHeader.tsx

@@ -113,11 +113,11 @@ export const PostCardHeader = ({
             <>
               {showCTA && (
                 <ReadArticleButton
-                  content={readButtonContent ?? postButtonText}
+                  content={readButtonContent ?? postButtonText ?? ''}
                   className="mr-2"
                   variant={ButtonVariant.Tertiary}
                   icon={readButtonIcon ?? <OpenLinkIcon />}
-                  href={postLink}
+                  href={postLink ?? ''}
                   onClick={onReadArticleClick}
                   openNewTab={openNewTab}
                 />

packages/shared/src/components/cards/share/SharedPostPreview.tsx

@@ -78,7 +78,7 @@ export function SharedPostPreview({
                   <SourceAvatar
                     source={{
                       image: sourceImage,
-                      handle: isUnknownSource ? unknownSource : source.handle,
+                      handle: isUnknownSource ? unknownSource : source!.handle,
                     }}
                     size={ProfileImageSize.Size16}
                     className="shrink-0"
@@ -89,7 +89,7 @@ export function SharedPostPreview({
                     color={TypographyColor.Primary}
                     className="truncate font-bold"
                   >
-                    {isUnknownSource ? unknownSource : source.name}
+                    {isUnknownSource ? unknownSource : source!.name}
                   </Typography>
                 </div>
               )}

packages/shared/src/components/comments/PlaceholderCommentList.tsx

@@ -13,8 +13,7 @@ export default function PlaceholderCommentList({
   placeholderAmount,
   ...props
 }: PlaceholderCommentListProps): ReactElement {
-  const amount =
-    placeholderAmount <= MAX_DISPLAY ? placeholderAmount : MAX_DISPLAY;
+  const amount = Math.min(placeholderAmount ?? MAX_DISPLAY, MAX_DISPLAY);
 
   return (
     <>

packages/shared/src/components/streak/ReadingStreakButton.tsx

@@ -57,7 +57,7 @@ function CustomStreaksTooltip({
         className: 'border border-border-subtlest-tertiary rounded-16',
       }}
       content={<ReadingStreakPopup streak={streak} />}
-      onClickOutside={() => setShouldShowStreaks(false)}
+      onClickOutside={() => setShouldShowStreaks!(false)}
     >
       {children}
     </SimpleTooltip>
@@ -70,15 +70,15 @@ export function ReadingStreakButton({
   compact,
   iconPosition,
   className,
-}: ReadingStreakButtonProps): ReactElement {
+}: ReadingStreakButtonProps): ReactElement | null {
   const { logEvent } = useLogContext();
   const { user } = useAuthContext();
   const isLaptop = useViewSize(ViewSize.Laptop);
   const isMobile = useViewSize(ViewSize.MobileL);
   const [shouldShowStreaks, setShouldShowStreaks] = useState(false);
   const hasReadToday =
     streak?.lastViewAt &&
-    isSameDayInTimezone(new Date(streak.lastViewAt), new Date(), user.timezone);
+    isSameDayInTimezone(new Date(streak.lastViewAt), new Date(), user!.timezone);
   const isTimezoneOk = useStreakTimezoneOk();
 
   const handleToggle = useCallback(() => {