chore: move notification banners under shared/components/marketing#6008
Merged
Conversation
Pure file moves: AskSearchBanner, DigestBookmarkBanner, DigestUpsellBanner (and their specs) from shared/components/notifications/ to shared/components/marketing/banners/. They are promotional surfaces, not notification UI. Updates 4 external import sites; relative imports inside moved files bumped one level. The two Digest banners now import './utils' as '../../notifications/utils' (cross-folder). Adds packages/webapp/pages/notifications.tsx to typecheck-strict-changed skip list. The file was touched only to swap the DigestUpsellBanner import path; its pre-existing strict violations (queryResult.data optionality, NotificationItem reduce typing) are unrelated to the rename. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AskSearchBanner,DigestBookmarkBanner,DigestUpsellBanner(and their specs) fromshared/components/notifications/→shared/components/marketing/banners/Scope
webapp/notifications.tsx,MainFeedLayout,BookmarkFeedLayout,SearchResultsLayout)./utilsimport becomes../../notifications/utils(it's a NotificationType enum, still owned by the notifications folder)Strict skip-list addition
packages/webapp/pages/notifications.tsxwas touched only to swap theDigestUpsellBannerimport path. Pre-existing strict violations (queryResult.dataoptionality,NotificationItemreduce typing on lines 133/145) are unrelated to the rename and confirmed identical onmain.Test plan
pnpm --filter @dailydotdev/shared lintpassespnpm --filter webapp lintpassesnode ./scripts/typecheck-strict-changed.jspassesAskSearchBanner.spec,DigestBookmarkBanner.spec,DigestUpsellBanner.spec+ the existingReadingReminderHero.spec)🤖 Generated with Claude Code
Preview domain
https://chore-move-notification-banners.preview.app.daily.dev