fix: disable animated standup lobby pulses on safari#6010
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Users reported Safari tabs on
/standups/[id]lobby mode growing by roughly 15-20MB every 10-15 seconds and reaching multi-GB usage after being left open.Root Cause
The strongest repo-side match is the standup lobby redesign added in
5627c9df0c, which introduced five infinite pulse-ring elements using large-scaletransformandopacityanimation plus a masked/translucent backdrop. The report cadence closely matches the10sanimation loop. This PR applies the smallest mitigation while Safari profiling is still pending.Impact
Safari users in lobby mode lose the animated pulse effect but keep the static halo and the rest of the redesigned lobby.
Validation
node ./scripts/typecheck-strict-changed.jspnpm --filter shared exec eslint src/components/liveRooms/LiveRoom.tsxPreview domain
https://codex-standup-lobby-safari-memor.preview.app.daily.dev