refactor: standup reminder icon state#6014
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
idoshamun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/standups/[id]lobby reminder CTA to show a checkmark icon after the user has already set a reminderLiveRoom.spec.tsxto assert the subscribed reminder CTA renders the checkmark stateWhy
The standup lobby kept showing a bell even after a reminder was set, so the visual state did not match the saved subscription state.
Impact
Users on scheduled standup lobbies now get a clear saved-state icon when their reminder is active.
Validation
NODE_ENV=test pnpm --filter shared test -- LiveRoom.spec.tsxnode ./scripts/typecheck-strict-changed.jsPreview domain
https://codex-standup-reminder-check-ico.preview.app.daily.dev