fix: refresh authenticated standup lobby joins#6023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
In production, scheduled standup lobbies can keep an anonymous resumed session alive after the app knows the user is logged in. That leaves the viewer in Flyting as an anonymous audience participant with
chatPermissions: false, which surfaces the misleading pre-live chat message instead of auto-joining correctly.User impact
Root cause
The shared live-room client reused any stored resume session for the room before fetching a new join token. If the stored session had been created anonymously, the client kept reconnecting as that anonymous participant even after auth was available.
Validation
NODE_ENV=test pnpm --filter shared test -- LiveRoomContext.spec.tsxnode ./scripts/typecheck-strict-changed.jsPreview domain
https://codex-fix-standup-lobby-authenti.preview.app.daily.dev