Skip to content

fix: refresh authenticated standup lobby joins#6023

Merged
idoshamun merged 1 commit into
mainfrom
codex/fix-standup-lobby-authenticated-rejoin
May 11, 2026
Merged

fix: refresh authenticated standup lobby joins#6023
idoshamun merged 1 commit into
mainfrom
codex/fix-standup-lobby-authenticated-rejoin

Conversation

@idoshamun
Copy link
Copy Markdown
Member

@idoshamun idoshamun commented May 11, 2026

What changed

  • refresh the live-room join flow when a logged-in user has a stored resume session for a different participant id
  • skip opening the websocket with that stale resume token and force a fresh authenticated join token instead
  • add a provider-level regression test for the authenticated rejoin path

Why

In production, scheduled standup lobbies can keep an anonymous resumed session alive after the app knows the user is logged in. That leaves the viewer in Flyting as an anonymous audience participant with chatPermissions: false, which surfaces the misleading pre-live chat message instead of auto-joining correctly.

User impact

  • signed-in hosts and viewers should recover from stale anonymous lobby sessions automatically
  • pre-live lobby chat should no longer stay disabled just because the browser reused an old anonymous resume token

Root cause

The shared live-room client reused any stored resume session for the room before fetching a new join token. If the stored session had been created anonymously, the client kept reconnecting as that anonymous participant even after auth was available.

Validation

  • NODE_ENV=test pnpm --filter shared test -- LiveRoomContext.spec.tsx
  • node ./scripts/typecheck-strict-changed.js

Preview domain

https://codex-fix-standup-lobby-authenti.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview May 11, 2026 8:58am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored May 11, 2026 8:58am

Request Review

@idoshamun idoshamun marked this pull request as ready for review May 11, 2026 08:56
@idoshamun idoshamun merged commit 4a3a187 into main May 11, 2026
15 checks passed
@idoshamun idoshamun deleted the codex/fix-standup-lobby-authenticated-rejoin branch May 11, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant