Skip to content

refactor(shared): remove shortcuts extension promo flag#6029

Merged
rebelchris merged 2 commits into
mainfrom
eng-1428-remove-shortcuts_extension_promo-feature-flag-apply-control
May 11, 2026
Merged

refactor(shared): remove shortcuts extension promo flag#6029
rebelchris merged 2 commits into
mainfrom
eng-1428-remove-shortcuts_extension_promo-feature-flag-apply-control

Conversation

@rebelchris
Copy link
Copy Markdown
Contributor

@rebelchris rebelchris commented May 11, 2026

Summary

  • remove the shortcuts_extension_promo feed promo banner path from MainFeedLayout
  • delete the ShortcutsExtensionPromo component and its related dismiss action enum
  • remove the now-unused shortcuts_extension_promo and shortcuts_extension_promo_copy feature exports

Key Decisions

  • applied the control variation permanently, so the promo banner is never shown
  • kept the shared shortcuts image assets intact because they are still used by extension new tab flows
  • simplified MainFeedLayout slightly by reusing a single isExtension check

Closes ENG-1428


Created by Huginn 🐦‍⬛

Preview domain

https://eng-1428-remove-shortcuts-extens.preview.app.daily.dev

@vercel
Copy link
Copy Markdown

vercel Bot commented May 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview May 11, 2026 1:26pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored May 11, 2026 1:26pm

Request Review

@rebelchris rebelchris merged commit 427dae0 into main May 11, 2026
12 checks passed
@rebelchris rebelchris deleted the eng-1428-remove-shortcuts_extension_promo-feature-flag-apply-control branch May 11, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant