refactor: remove anon props (#3276)

Author: AmarTrebinjac

__tests__/schema/profile.ts

@@ -196,37 +196,6 @@ describe('query userExperiences', () => {
     expect(res.data.userExperiences.edges).toHaveLength(1);
   });
 
-  it('should restrict fields for anonymous users to only allowed columns', async () => {
-    loggedUser = null;
-
-    const res = await client.query(USER_EXPERIENCES_QUERY, {
-      variables: { userId: '1' },
-    });
-
-    expect(res.errors).toBeFalsy();
-    expect(res.data.userExperiences.edges).toHaveLength(1);
-
-    const experience = res.data.userExperiences.edges[0].node;
-
-    // Allowed columns for anonymous users
-    expect(experience).toMatchObject({
-      id: 'f47ac10b-58cc-4372-a567-0e02b2c3d479',
-      type: 'work',
-      title: 'Senior Software Engineer',
-      company: {
-        id: 'company-1',
-        name: 'Daily.dev',
-      },
-    });
-
-    // Restricted columns should be null for anonymous users
-    expect(experience.subtitle).toBeNull();
-    expect(experience.description).toBeNull();
-    expect(experience.startedAt).toBeNull();
-    expect(experience.endedAt).toBeNull();
-    expect(experience.createdAt).toBeNull();
-  });
-
   it('should return all fields for logged-in users', async () => {
     loggedUser = '1';
 
@@ -515,35 +484,6 @@ describe('query userExperienceById', () => {
     });
   });
 
-  it('should restrict fields for anonymous users when fetching by id', async () => {
-    loggedUser = null;
-
-    const res = await client.query(USER_EXPERIENCE_BY_ID_QUERY, {
-      variables: { id: 'f47ac10b-58cc-4372-a567-0e02b2c3d479' },
-    });
-
-    expect(res.errors).toBeFalsy();
-
-    const experience = res.data.userExperienceById;
-
-    // Allowed columns for anonymous users
-    expect(experience).toMatchObject({
-      id: 'f47ac10b-58cc-4372-a567-0e02b2c3d479',
-      type: 'work',
-      title: 'Senior Software Engineer',
-      company: {
-        name: 'Daily.dev',
-      },
-    });
-
-    // Restricted columns should be null for anonymous users
-    expect(experience.subtitle).toBeNull();
-    expect(experience.description).toBeNull();
-    expect(experience.startedAt).toBeNull();
-    expect(experience.endedAt).toBeNull();
-    expect(experience.createdAt).toBeNull();
-  });
-
   it('should return experience from another user', async () => {
     loggedUser = '1';
 

src/common/schema/profile.ts

@@ -48,7 +48,10 @@ export const userExperienceWorkSchema = z
     externalReferenceId: z.string().optional(),
     employmentType: z.number().nullable().optional().default(null),
     locationType: z.number().nullable().optional().default(null),
-    locationId: z.uuidv4().nullable().optional().default(null),
+    locationId: z.preprocess(
+      (val) => (val === '' ? null : val),
+      z.string().uuid().nullable().optional().default(null),
+    ),
     skills: z
       .array(z.string().trim().normalize().nonempty().max(100))
       .max(50)

src/graphorm/index.ts

@@ -1726,17 +1726,6 @@ const obj = new GraphORM({
     from: 'DatasetLocation',
   },
   UserExperience: {
-    anonymousRestrictedColumns: [
-      'user',
-      'subtitle',
-      'description',
-      'startedAt',
-      'endedAt',
-      'location',
-      'locationType',
-      'createdAt',
-      'updatedAt',
-    ],
     fields: {
       startedAt: {
         transform: transformDate,